use `%(sysroot)s` template in `wget` easyconfigs to define `PKG_CONFIG_PATH` by xinan1911 · Pull Request #19080 · easybuilders/easybuild-easyconfigs

xinan1911 · 2023-10-25T11:54:01Z

(created using eb --new-pr)

xinan1911 · 2023-10-25T11:59:29Z

This pr depends on another pr in easybuild-framework easybuilders/easybuild-framework#4359.

casparvl · 2023-10-26T08:33:55Z

@boegelbot please test @ generoso

boegelbot · 2023-10-26T08:35:05Z

@casparvl: Request for testing this PR well received on login1

PR test command 'EB_PR=19080 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_19080 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

exit code: 0
output:

Submitted batch job 12058

Test results coming soon (I hope)...

Details

- notification for comment with ID 1780658859 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

casparvl · 2023-10-26T12:09:24Z

Test report by @casparvl
SUCCESS
Build succeeded for 6 out of 6 (6 easyconfigs in total)
tcn1.local.snellius.surf.nl - Linux RHEL 8.6, x86_64, AMD EPYC 7H12 64-Core Processor, Python 3.6.8
See https://gist.github.com/casparvl/55f3383c28ba7b3e15ed9abeaf1ab86b for a full test report.

casparvl · 2023-10-26T16:27:07Z

Test report by @casparvl
SUCCESS
Build succeeded for 6 out of 6 (6 easyconfigs in total)
tcn1.local.snellius.surf.nl - Linux RHEL 8.6, x86_64, AMD EPYC 7H12 64-Core Processor, Python 3.6.8
See https://gist.github.com/casparvl/d353d58ec68df8f62f4e02f594bde25d for a full test report.

casparvl · 2023-10-26T16:27:46Z

@boegelbot please test @ generoso
EB_ARGS="wget-1.20.1-GCCcore-8.3.0.eb wget-1.20.3-GCCcore-10.2.0.eb wget-1.20.3-GCCcore-9.3.0.eb wget-1.21.1-GCCcore-10.3.0.eb wget-1.21.2-GCCcore-11.2.0.eb wget-1.21.3-GCCcore-11.3.0.eb"

casparvl · 2023-10-26T16:28:30Z

N.B. I'm not testing the oldest wget's, those toolchains are deprecated anyway, and on my local system I couldn't build those toolchains anymore. Maybe that's also why generoso didn't return earlier with a result... hoping this works :)

boegelbot · 2023-10-26T16:30:07Z

@casparvl: Request for testing this PR well received on login1

PR test command 'EB_PR=19080 EB_ARGS="wget-1.20.1-GCCcore-8.3.0.eb wget-1.20.3-GCCcore-10.2.0.eb wget-1.20.3-GCCcore-9.3.0.eb wget-1.21.1-GCCcore-10.3.0.eb wget-1.21.2-GCCcore-11.2.0.eb wget-1.21.3-GCCcore-11.3.0.eb" EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_19080 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

exit code: 0
output:

Submitted batch job 12060

Test results coming soon (I hope)...

Details

- notification for comment with ID 1781454402 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

casparvl · 2023-10-26T17:21:25Z

@boegelbot please test @ jsc-zen2
EB_ARGS="wget-1.20.1-GCCcore-8.3.0.eb wget-1.20.3-GCCcore-10.2.0.eb wget-1.20.3-GCCcore-9.3.0.eb wget-1.21.1-GCCcore-10.3.0.eb wget-1.21.2-GCCcore-11.2.0.eb wget-1.21.3-GCCcore-11.3.0.eb"

boegelbot · 2023-10-26T17:25:11Z

@casparvl: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=19080 EB_ARGS="wget-1.20.1-GCCcore-8.3.0.eb wget-1.20.3-GCCcore-10.2.0.eb wget-1.20.3-GCCcore-9.3.0.eb wget-1.21.1-GCCcore-10.3.0.eb wget-1.21.2-GCCcore-11.2.0.eb wget-1.21.3-GCCcore-11.3.0.eb" EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --mem-per-cpu=4000M --job-name test_PR_19080 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

exit code: 0
output:

Submitted batch job 3648

Test results coming soon (I hope)...

Details

- notification for comment with ID 1781532360 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

boegel · 2023-10-27T06:38:41Z

@boegelbot please test @ jsc-zen2
EB_ARGS="wget-1.20.1-GCCcore-8.3.0.eb wget-1.20.3-GCCcore-10.2.0.eb wget-1.20.3-GCCcore-9.3.0.eb wget-1.21.1-GCCcore-10.3.0.eb wget-1.21.2-GCCcore-11.2.0.eb wget-1.21.3-GCCcore-11.3.0.eb"

boegelbot · 2023-10-27T06:40:09Z

@boegel: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=19080 EB_ARGS="wget-1.20.1-GCCcore-8.3.0.eb wget-1.20.3-GCCcore-10.2.0.eb wget-1.20.3-GCCcore-9.3.0.eb wget-1.21.1-GCCcore-10.3.0.eb wget-1.21.2-GCCcore-11.2.0.eb wget-1.21.3-GCCcore-11.3.0.eb" EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --mem-per-cpu=4000M --job-name test_PR_19080 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

exit code: 0
output:

Submitted batch job 3649

Test results coming soon (I hope)...

Details

- notification for comment with ID 1782378584 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

boegelbot · 2023-10-27T06:45:32Z

Test report by @boegelbot
SUCCESS
Build succeeded for 6 out of 6 (6 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/boegelbot/6d286dfc89df929075e5aacc78542488 for a full test report.

boegel

lgtm

boegel · 2023-10-27T07:09:08Z

I've verified that this works in the EESSI build environment as intended 👍

boegel · 2023-10-27T07:19:53Z

@boegelbot please test @ generoso
EB_ARGS="wget-1.20.1-GCCcore-7.3.0.eb wget-1.20.1-GCCcore-8.3.0.eb wget-1.20.3-GCCcore-10.2.0.eb wget-1.20.3-GCCcore-9.3.0.eb wget-1.21.1-GCCcore-10.3.0.eb wget-1.21.2-GCCcore-11.2.0.eb wget-1.21.3-GCCcore-11.3.0.eb "

boegelbot · 2023-10-27T07:30:05Z

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=19080 EB_ARGS="wget-1.20.1-GCCcore-7.3.0.eb wget-1.20.1-GCCcore-8.3.0.eb wget-1.20.3-GCCcore-10.2.0.eb wget-1.20.3-GCCcore-9.3.0.eb wget-1.21.1-GCCcore-10.3.0.eb wget-1.21.2-GCCcore-11.2.0.eb wget-1.21.3-GCCcore-11.3.0.eb " EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_19080 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

exit code: 0
output:

Submitted batch job 12065

Test results coming soon (I hope)...

Details

- notification for comment with ID 1782422633 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

boegel · 2023-10-27T07:35:25Z

Test report by @boegel
SUCCESS
Build succeeded for 6 out of 6 (6 easyconfigs in total)
node3100.skitty.os - Linux RHEL 8.8, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/boegel/920f21f8aebce17bf1fe6f5f40d013c7 for a full test report.

boegelbot · 2023-10-27T07:40:00Z

Test report by @boegelbot
SUCCESS
Build succeeded for 7 out of 7 (7 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/abc218a2f337a7c6e306d078d7732993 for a full test report.

boegel · 2023-10-27T08:44:03Z

Going in, thanks @xinan1911!

generalize wget using sysroot template

07a85a6

fix style for long lines

6061636

xinan1911 changed the title ~~generalize wget using sysroot template~~ Generalize wget using sysroot template Oct 26, 2023

casparvl added the EESSI Related to EESSI project label Oct 26, 2023

casparvl added this to the next release (4.8.2?) milestone Oct 26, 2023

easybuilders deleted a comment from boegelbot Oct 27, 2023

boegel changed the title ~~Generalize wget using sysroot template~~ use sysroot template in wget easyconfigs to define PKG_CONFIG_PATH Oct 27, 2023

boegel approved these changes Oct 27, 2023

View reviewed changes

easybuilders deleted a comment from boegelbot Oct 27, 2023

boegel mentioned this pull request Oct 27, 2023

{2023.06}[foss/2022a] DP3 6.0 and WSClean 3.4 EESSI/software-layer#370

Merged

boegel merged commit af1ba41 into easybuilders:develop Oct 27, 2023

boegel added the bug fix label Oct 29, 2023

boegel changed the title ~~use sysroot template in wget easyconfigs to define PKG_CONFIG_PATH~~ use %(sysroot)s template in wget easyconfigs to define PKG_CONFIG_PATH Nov 8, 2023

Conversation

xinan1911 commented Oct 25, 2023

Uh oh!

xinan1911 commented Oct 25, 2023

Uh oh!

casparvl commented Oct 26, 2023

Uh oh!

boegelbot commented Oct 26, 2023

Uh oh!

casparvl commented Oct 26, 2023

Uh oh!

casparvl commented Oct 26, 2023

Uh oh!

casparvl commented Oct 26, 2023

Uh oh!

casparvl commented Oct 26, 2023

Uh oh!

boegelbot commented Oct 26, 2023

Uh oh!

casparvl commented Oct 26, 2023

Uh oh!

boegelbot commented Oct 26, 2023

Uh oh!

boegel commented Oct 27, 2023

Uh oh!

boegelbot commented Oct 27, 2023

Uh oh!

boegelbot commented Oct 27, 2023

Uh oh!

boegel left a comment

Choose a reason for hiding this comment

Uh oh!

boegel commented Oct 27, 2023

Uh oh!

boegel commented Oct 27, 2023

Uh oh!

boegelbot commented Oct 27, 2023

Uh oh!

boegel commented Oct 27, 2023

Uh oh!

boegelbot commented Oct 27, 2023

Uh oh!

boegel commented Oct 27, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants