Skip to content

only set flag --enable-asmjit for PLUMED when installing on x86_64#19110

Merged
bedroge merged 2 commits intoeasybuilders:developfrom
laraPPr:20231030103644_new_pr_PLUMED262
Nov 1, 2023
Merged

only set flag --enable-asmjit for PLUMED when installing on x86_64#19110
bedroge merged 2 commits intoeasybuilders:developfrom
laraPPr:20231030103644_new_pr_PLUMED262

Conversation

@laraPPr
Copy link
Copy Markdown
Contributor

@laraPPr laraPPr commented Oct 30, 2023

(created using eb --new-pr)

@laraPPr laraPPr changed the title Only set flag --enable-asmjit when installing on x86_64 Only set flag --enable-asmjit when installing on x86_64 Oct 30, 2023
@laraPPr
Copy link
Copy Markdown
Contributor Author

laraPPr commented Oct 30, 2023

Test report by @laraPPr
SUCCESS
Build succeeded for 9 out of 9 (7 easyconfigs in total)
node3511.doduo.os - Linux RHEL 8.8, x86_64, AMD EPYC 7552 48-Core Processor, Python 3.6.8
See https://gist.github.com/laraPPr/ef82525946cdb04aad069a49debf21b2 for a full test report.

@laraPPr laraPPr mentioned this pull request Oct 30, 2023
Merged
@laraPPr
Copy link
Copy Markdown
Contributor Author

laraPPr commented Oct 30, 2023 •
edited
Loading

@bedroge can you review and add the labels eessi and bug fix?

@bedroge bedroge added bug fix EESSI Related to EESSI project labels Nov 1, 2023
@bedroge
Copy link
Copy Markdown
Contributor

bedroge commented Nov 1, 2023

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Nov 1, 2023

@bedroge: Request for testing this PR well received on login1

PR test command 'EB_PR=19110 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_19110 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 12081

Test results coming soon (I hope)...

Details

- notification for comment with ID 1788626730 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Nov 1, 2023

Test report by @boegelbot
SUCCESS
Build succeeded for 7 out of 7 (7 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/af0df6831de47f81aac7e68eb034c12d for a full test report.

@bedroge
Copy link
Copy Markdown
Contributor

bedroge commented Nov 1, 2023

@boegelbot please test @ jsc-zen2

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Nov 1, 2023

@bedroge: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=19110 EB_ARGS= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --mem-per-cpu=4000M --job-name test_PR_19110 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 3659

Test results coming soon (I hope)...

Details

- notification for comment with ID 1788700911 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Nov 1, 2023

Test report by @boegelbot
SUCCESS
Build succeeded for 7 out of 7 (7 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/boegelbot/fecce0b9f7f225f38dde04c14592e06e for a full test report.

bedroge
bedroge approved these changes Nov 1, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@bedroge bedroge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@bedroge bedroge changed the title Only set flag --enable-asmjit when installing on x86_64 only set flag --enable-asmjit for PLUMED when installing on x86_64 Nov 1, 2023
@bedroge bedroge added this to the next release (4.9.0?) milestone Nov 1, 2023
@bedroge
Copy link
Copy Markdown
Contributor

bedroge commented Nov 1, 2023

Going in, thanks @laraPPr!

@bedroge bedroge merged commit ad461be into easybuilders:develop Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bedroge bedroge bedroge approved these changes

Assignees

No one assigned

Labels

bug fix EESSI Related to EESSI project

Projects

None yet

Milestone

4.9.0

Development

Successfully merging this pull request may close these issues.

3 participants

@laraPPr @bedroge @boegelbot