Skip to content

add patch to fix detection of newer Intel CPUs in OpenBLAS 0.3.20-0.3.23#19141

Merged
boegel merged 1 commit intoeasybuilders:developfrom
Flamefire:20231102102215_new_pr_OpenBLAS0320
Nov 5, 2023
Merged

add patch to fix detection of newer Intel CPUs in OpenBLAS 0.3.20-0.3.23#19141
boegel merged 1 commit intoeasybuilders:developfrom
Flamefire:20231102102215_new_pr_OpenBLAS0320

Conversation

@Flamefire
Copy link
Copy Markdown
Contributor

@Flamefire Flamefire commented Nov 2, 2023

(created using eb --new-pr)

@branfosj branfosj added this to the next release (4.9.0?) milestone Nov 2, 2023
@branfosj
Copy link
Copy Markdown
Member

branfosj commented Nov 2, 2023

Test report by @branfosj
SUCCESS
Build succeeded for 5 out of 5 (5 easyconfigs in total)
bear-pg0105u03a - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Platinum 8360Y CPU @ 2.40GHz (icelake), Python 3.6.8
See https://gist.github.com/branfosj/25272be6f5629a74bb04879833a1d889 for a full test report.

@Flamefire Flamefire mentioned this pull request Nov 2, 2023
Closed
@Flamefire
Copy link
Copy Markdown
Contributor Author

Flamefire commented Nov 2, 2023

This might be failing on actual SapphireRapids (for which I made that change) due to #19021 -.-

@Flamefire
Copy link
Copy Markdown
Contributor Author

Flamefire commented Nov 2, 2023 •
edited
Loading

Test report by @Flamefire
FAILED
Build succeeded for 1 out of 5 (5 easyconfigs in total)
n1604 - Linux RHEL 8.7 (Ootpa), x86_64, Intel(R) Xeon(R) Platinum 8470 (icelake), Python 3.8.13
See https://gist.github.com/Flamefire/b20a2f2d0dbef6718eb9fb25a4e6b9ba for a full test report.

Edit: This is the mentioned issue on Rapids. For some reason the NVHPC variant works though...

@Flamefire
Copy link
Copy Markdown
Contributor Author

Flamefire commented Nov 3, 2023

Test report by @Flamefire
SUCCESS
Build succeeded for 6 out of 6 (5 easyconfigs in total)
taurusi6605.taurus.hrsk.tu-dresden.de - Linux RHEL 7.9, x86_64, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz (haswell), Python 2.7.5
See https://gist.github.com/Flamefire/ae25715fdf050f2d0e802dd1207d8dde for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Nov 5, 2023

@boegelbot please test @ generoso

@boegel boegel changed the title fix detection of newer Intel CPUs in OpenBLAS 0.3.20-0.3.23 add patch to fix detection of newer Intel CPUs in OpenBLAS 0.3.20-0.3.23 Nov 5, 2023
boegel
boegel approved these changes Nov 5, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Nov 5, 2023

Test report by @boegelbot
SUCCESS
Build succeeded for 5 out of 5 (5 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/6a4d8c582403bf2eb14761bbf4aee46e for a full test report.

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Nov 5, 2023

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=19141 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_19141 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 12107

Test results coming soon (I hope)...

Details

- notification for comment with ID 1793666007 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegel
Copy link
Copy Markdown
Member

boegel commented Nov 5, 2023

@boegelbot please test @ jsc-zen2

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Nov 5, 2023

@boegel: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=19141 EB_ARGS= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --mem-per-cpu=4000M --job-name test_PR_19141 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 3685

Test results coming soon (I hope)...

Details

- notification for comment with ID 1793667165 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Nov 5, 2023

Test report by @boegelbot
SUCCESS
Build succeeded for 5 out of 5 (5 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/boegelbot/51bf81be139082eca74a54a54f9428a0 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Nov 5, 2023

Test report by @boegel
SUCCESS
Build succeeded for 35 out of 35 (5 easyconfigs in total)
node3153.skitty.os - Linux RHEL 8.8, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/boegel/c1f17ba4444fc8b58b8c916501bc500e for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Nov 5, 2023

Going in, thanks @Flamefire!

@boegel boegel merged commit 65bee0a into easybuilders:develop Nov 5, 2023
@Flamefire Flamefire deleted the 20231102102215_new_pr_OpenBLAS0320 branch November 6, 2023 08:08
@Flamefire Flamefire mentioned this pull request Nov 6, 2023
Merged
@Flamefire
Copy link
Copy Markdown
Contributor Author

Flamefire commented Nov 6, 2023

PR to fix the failures on Sapphire Rapids (still reported as "icelake" by archspec above) and Cooperlake CPUs at #19159

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.9.0

Development

Successfully merging this pull request may close these issues.

4 participants

@Flamefire @branfosj @boegel @boegelbot