Skip to content

{tools}[GCCcore/10.2.0,GCCcore/12.2.0] f90nml v1.4.4#19171

Merged
akesandgren merged 3 commits intoeasybuilders:developfrom
SimonPinches:20231107174742_new_pr_f90nml144
Jan 8, 2024
Merged

{tools}[GCCcore/10.2.0,GCCcore/12.2.0] f90nml v1.4.4#19171
akesandgren merged 3 commits intoeasybuilders:developfrom
SimonPinches:20231107174742_new_pr_f90nml144

Conversation

@SimonPinches
Copy link
Copy Markdown
Contributor

@SimonPinches SimonPinches commented Nov 7, 2023

(created using eb --new-pr)

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Nov 7, 2023

@SimonPinches: Tests failed in GitHub Actions, see https://github.com/easybuilders/easybuild-easyconfigs/actions/runs/6787672141
Output from first failing test suite run:

FAIL: test_pr_python_packages (test.easyconfigs.easyconfigs.EasyConfigTest)
Several checks for easyconfigs that install (bundles of) Python packages.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/runner/work/easybuild-easyconfigs/easybuild-easyconfigs/test/easyconfigs/easyconfigs.py", line 1116, in test_pr_python_packages
    self.fail('\n'.join(failing_checks))
AssertionError: 'source_urls' should not be defined when using the default value in f90nml-1.4.4-GCCcore-10.2.0.eb
'source_urls' should not be defined when using the default value in f90nml-1.4.4-GCCcore-12.2.0.eb

----------------------------------------------------------------------
Ran 18490 tests in 688.255s

FAILED (failures=1)
ERROR: Not all tests were successful

bleep, bloop, I'm just a bot (boegelbot v20200716.01)
Please talk to my owner @boegel if you notice me acting stupid),
or submit a pull request to https://github.com/boegel/boegelbot fix the problem.

@SimonPinches SimonPinches force-pushed the 20231107174742_new_pr_f90nml144 branch from 4025545 to 259e4d4 Compare November 8, 2023 17:00
@akesandgren akesandgren added the new label Jan 5, 2024
akesandgren
akesandgren requested changes Jan 5, 2024
View reviewed changes
Comment thread easybuild/easyconfigs/f/f90nml/f90nml-1.4.4-GCCcore-10.2.0.eb
description = """A Python module and command line tool for parsing
Fortran namelist files"""

toolchain = {'name': 'GCCcore', 'version': '10.2.0'}
Copy link
Copy Markdown
Contributor

@akesandgren akesandgren Jan 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This belongs to the foss/2020b toolchain which has been deprecated (https://docs.easybuild.io/policies/toolchains/)

I suggest dropping it from the PR.

Copy link
Copy Markdown
Contributor Author

@SimonPinches SimonPinches Jan 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, it wasn't deprecated when I submitted this :-)
I hope it's okay if I move it to the archive folder. We still actively use 2020b so it would be nice to keep this EB file somewhere.
I've also added the GCCcore/13.2.0 version.

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jan 5, 2024

@SimonPinches: Tests failed in GitHub Actions, see https://github.com/easybuilders/easybuild-easyconfigs/actions/runs/7423085067
Output from first failing test suite run:

FAIL: test_pr_python_packages (test.easyconfigs.easyconfigs.EasyConfigTest)
Several checks for easyconfigs that install (bundles of) Python packages.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/runner/work/easybuild-easyconfigs/easybuild-easyconfigs/test/easyconfigs/easyconfigs.py", line 1114, in test_pr_python_packages
    self.fail('\n'.join(failing_checks))
AssertionError: 'source_urls' should not be defined when using the default value in f90nml-1.4.4-GCCcore-13.2.0.eb

----------------------------------------------------------------------
Ran 18811 tests in 707.211s

FAILED (failures=1)
ERROR: Not all tests were successful

bleep, bloop, I'm just a bot (boegelbot v20200716.01)
Please talk to my owner @boegel if you notice me acting stupid),
or submit a pull request to https://github.com/boegel/boegelbot fix the problem.

@akesandgren
Copy link
Copy Markdown
Contributor

akesandgren commented Jan 8, 2024

@boegelbot Please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jan 8, 2024

@akesandgren: Request for testing this PR well received on login1

PR test command 'EB_PR=19171 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_19171 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 12530

Test results coming soon (I hope)...

Details

- notification for comment with ID 1880531060 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jan 8, 2024

Test report by @boegelbot
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/2c78030f4e0c605e49963ea0a44088f9 for a full test report.

@akesandgren akesandgren added this to the release after 4.9.0 milestone Jan 8, 2024
akesandgren
akesandgren approved these changes Jan 8, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@akesandgren akesandgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akesandgren
Copy link
Copy Markdown
Contributor

akesandgren commented Jan 8, 2024

Going in, thanks @SimonPinches!

@akesandgren akesandgren merged commit 192d18e into easybuilders:develop Jan 8, 2024
@SimonPinches SimonPinches deleted the 20231107174742_new_pr_f90nml144 branch January 11, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akesandgren akesandgren akesandgren approved these changes

Assignees

No one assigned

Labels

new

Projects

None yet

Milestone

4.9.1

Development

Successfully merging this pull request may close these issues.

3 participants

@SimonPinches @boegelbot @akesandgren