Skip to content

Sidestep some build issues with CUDA-Samples 12.1#19189

Merged
smoors merged 2 commits intoeasybuilders:developfrom
ocaisa:20231110163438_new_pr_CUDA-Samples121
Nov 14, 2023
Merged

Sidestep some build issues with CUDA-Samples 12.1#19189
smoors merged 2 commits intoeasybuilders:developfrom
ocaisa:20231110163438_new_pr_CUDA-Samples121

Conversation

@ocaisa
Copy link
Copy Markdown
Member

@ocaisa ocaisa commented Nov 10, 2023 •
edited by boegel
Loading

(created using eb --new-pr)

edit (by @boegel): this side-steps linking issues like this in EESSI:

 /cvmfs/pilot.eessi-hpc.org/versions/2023.06/compat/linux/x86_64/usr/bin/ld: /cvmfs/pilot.eessi-hpc.org/versions/2023.06/software/linux/x86_64/intel/skylake_avx512/software/GCCcore/12.3.0/lib/
gcc/x86_64-pc-linux-gnu/12.3.0/../../../../lib64/libstdc++.so: undefined reference to `pthread_setspecific@GLIBC_2.34'

In the mean time, @casparvl has figured out that this occurs because -L/usr/lib/x86_64-linux-gnu -L/usr/lib64 is hardcoded in the makefile, so there's a way to fix those linking issues (by using %(sysroot)s to patch the hardcoded system paths in the makefile)

@smoors smoors added the bug fix label Nov 13, 2023
@smoors
Copy link
Copy Markdown
Contributor

smoors commented Nov 13, 2023

@boegelbot please test @ jsc-zen2

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Nov 13, 2023

@smoors: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=19189 EB_ARGS= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --mem-per-cpu=4000M --job-name test_PR_19189 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 3725

Test results coming soon (I hope)...

Details

- notification for comment with ID 1808892482 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Nov 13, 2023

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/boegelbot/d07d3240c92e4daf22d4702d02716692 for a full test report.

@smoors
Copy link
Copy Markdown
Contributor

smoors commented Nov 13, 2023

@boegelbot: please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Nov 13, 2023

@smoors: Request for testing this PR well received on login1

PR test command 'EB_PR=19189 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_19189 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 12162

Test results coming soon (I hope)...

Details

- notification for comment with ID 1808921673 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Nov 13, 2023

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns2 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/f2efe173eb06dfc6c8af4cc48f264c69 for a full test report.

smoors
smoors approved these changes Nov 14, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@smoors smoors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smoors smoors added this to the next release (4.9.0?) milestone Nov 14, 2023
@smoors
Copy link
Copy Markdown
Contributor

smoors commented Nov 14, 2023

Going in, thanks @ocaisa!

@smoors smoors merged commit cc69baa into easybuilders:develop Nov 14, 2023
@boegel boegel mentioned this pull request Nov 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smoors smoors smoors approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.9.0

Development

Successfully merging this pull request may close these issues.

3 participants

@ocaisa @smoors @boegelbot