Skip to content

{lang}[GCCcore/11.3.0] cppyy v3.0.0#19204

Merged
jfgrimm merged 2 commits intoeasybuilders:developfrom
migueldiascosta:20231111201123_new_pr_cppyy300
Nov 27, 2023
Merged

{lang}[GCCcore/11.3.0] cppyy v3.0.0#19204
jfgrimm merged 2 commits intoeasybuilders:developfrom
migueldiascosta:20231111201123_new_pr_cppyy300

Conversation

@migueldiascosta
Copy link
Copy Markdown
Member

(created using eb --new-pr)

@migueldiascosta
Copy link
Copy Markdown
Member Author

@boegelbot please test @ generoso

@migueldiascosta migueldiascosta added this to the next release (4.9.0?) milestone Nov 11, 2023
@boegelbot
Copy link
Copy Markdown
Collaborator

@migueldiascosta: Request for testing this PR well received on login1

PR test command 'EB_PR=19204 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_19204 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 12145

Test results coming soon (I hope)...

Details

- notification for comment with ID 1806800796 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
FAILED
Build succeeded for 0 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/05bc291d7f84335810b11598e0a52844 for a full test report.

@migueldiascosta
Copy link
Copy Markdown
Member Author

@boegelbot please test @ jsc-zen2

@boegelbot
Copy link
Copy Markdown
Collaborator

@migueldiascosta: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=19204 EB_ARGS= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --mem-per-cpu=4000M --job-name test_PR_19204 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 3712

Test results coming soon (I hope)...

Details

- notification for comment with ID 1806802163 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
FAILED
Build succeeded for 0 out of 1 (1 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/boegelbot/df2877823f11725ad427b0eb3987464a for a full test report.

boegel
boegel previously approved these changes Nov 12, 2023
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Copy Markdown
Member

boegel commented Nov 12, 2023

@migueldiascosta

  In file included from /tmp/boegelbot/cppyy/3.0.0/GCCcore-11.3.0/cppyycling/cppyy-cling-6.28.0/src/interpreter/llvm/src/include/llvm/Support/BinaryStreamReader.h:16,
                   from /tmp/boegelbot/cppyy/3.0.0/GCCcore-11.3.0/cppyycling/cppyy-cling-6.28.0/src/interpreter/llvm/src/lib/Support/BinaryStreamReader.cpp:9:
  /tmp/boegelbot/cppyy/3.0.0/GCCcore-11.3.0/cppyycling/cppyy-cling-6.28.0/src/interpreter/llvm/src/include/llvm/Support/BinaryStreamArray.h:331:31: error: expected unqualified-id before const
    331 |   FixedStreamArrayIterator<T>(const FixedStreamArrayIterator<T> &Other)
        |                               ^~~~~
  /tmp/boegelbot/cppyy/3.0.0/GCCcore-11.3.0/cppyycling/cppyy-cling-6.28.0/src/interpreter/llvm/src/include/llvm/Support/BinaryStreamArray.h:331:31: error: expected ) before const
    331 |   FixedStreamArrayIterator<T>(const FixedStreamArrayIterator<T> &Other)
        |                              ~^~~~~
        |                               )

@migueldiascosta
Copy link
Copy Markdown
Member Author

migueldiascosta commented Nov 13, 2023

  In file included from /tmp/boegelbot/cppyy/3.0.0/GCCcore-11.3.0/cppyycling/cppyy-cling-6.28.0/src/interpreter/llvm/src/include/llvm/Support/BinaryStreamReader.h:16,
                   from /tmp/boegelbot/cppyy/3.0.0/GCCcore-11.3.0/cppyycling/cppyy-cling-6.28.0/src/interpreter/llvm/src/lib/Support/BinaryStreamReader.cpp:9:
  /tmp/boegelbot/cppyy/3.0.0/GCCcore-11.3.0/cppyycling/cppyy-cling-6.28.0/src/interpreter/llvm/src/include/llvm/Support/BinaryStreamArray.h:331:31: error: expected unqualified-id before const
    331 |   FixedStreamArrayIterator<T>(const FixedStreamArrayIterator<T> &Other)
        |                               ^~~~~
  /tmp/boegelbot/cppyy/3.0.0/GCCcore-11.3.0/cppyycling/cppyy-cling-6.28.0/src/interpreter/llvm/src/include/llvm/Support/BinaryStreamArray.h:331:31: error: expected ) before const
    331 |   FixedStreamArrayIterator<T>(const FixedStreamArrayIterator<T> &Other)
        |                              ~^~~~~
        |                               )

weird, I was able to build cppyy in the system where I was writing the easyconfigs (edit: rebuilt it now using --from-pr, test report at https://gist.github.com/migueldiascosta/8c6b7d33f22c7b946ff4d629c673b001), but I'm also able to reproduce this error on another, no idea what difference could explain this, will need to dig further later

@verdurin
Copy link
Copy Markdown
Member

Test report by @verdurin
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
easybuild-c7.novalocal - Linux CentOS Linux 7.9.2009, x86_64, Intel Xeon Processor (Skylake, IBRS), Python 3.6.8
See https://gist.github.com/verdurin/a144c88bdd9e965527416164c9761dc1 for a full test report.

@migueldiascosta
Copy link
Copy Markdown
Member Author

migueldiascosta commented Nov 25, 2023

ffs... in cppyy-cling's setup.py:

# get C++ standard to use, if set
        try:
            stdcxx = os.environ['STDCXX']
        except KeyError:
            if is_manylinux():
                stdcxx = '14'
            else:
                stdcxx = '20'
_is_manylinux = None
def is_manylinux():
    global _is_manylinux
    if _is_manylinux is None:
        _is_manylinux = False
        try:
            for line in open('/etc/redhat-release').readlines():
              # mark manylinux1, manylinux2010, or manylinux2014
                if 'CentOS release 5.11 (Final)' in line or \
                   'CentOS release 6.10 (Final)' in line or \
                   'CentOS Linux release 7.9.2009 (Core)' in line:
                    _is_manylinux = True
                    break
        except (OSError, IOError):
            pass
    return _is_manylinux

so, only those three particular versions of CentOS in particular are manylinux (eye roll...)

nevermind, let's try with

('cppyy-cling', '6.28.0', {
        'modulename': False,
        'preinstallopts': 'export STDCXX=14 && ',
        'checksums': ['ae67fc338510d03b68dde08add5b519e2c6434d40fe07e23e7ebace3caa684e7'],
    }),

@migueldiascosta
Copy link
Copy Markdown
Member Author

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

@migueldiascosta: Request for testing this PR well received on login1

PR test command 'EB_PR=19204 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_19204 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 12252

Test results coming soon (I hope)...

Details

- notification for comment with ID 1826371415 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@zao
Copy link
Copy Markdown
Contributor

zao commented Nov 25, 2023

Test report by @zao
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
eb-mix.zao.se - Linux Ubuntu 22.04.3 LTS (Jammy Jellyfish), x86_64, AMD Ryzen 9 3900X 12-Core Processor (zen2), Python 3.10.12
See https://gist.github.com/zao/6c71a34d3a19710fc0c8017a51c2c9fa for a full test report.

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns2 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/f79861d56308d16deedbe26951152be9 for a full test report.

@migueldiascosta
Copy link
Copy Markdown
Member Author

@boegelbot please test @ jsc-zen2

@boegelbot
Copy link
Copy Markdown
Collaborator

@migueldiascosta: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=19204 EB_ARGS= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --mem-per-cpu=4000M --job-name test_PR_19204 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 3800

Test results coming soon (I hope)...

Details

- notification for comment with ID 1826383164 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@migueldiascosta
Copy link
Copy Markdown
Member Author

@boegelbot please test @ jsc-zen2 CORE_CNT=16

@boegelbot
Copy link
Copy Markdown
Collaborator

@migueldiascosta: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=19204 EB_ARGS= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --mem-per-cpu=4000M --job-name test_PR_19204 --ntasks="16" ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 3801

Test results coming soon (I hope)...

Details

- notification for comment with ID 1826438948 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/boegelbot/89ed29d24212be7c5a68425288e2c13c for a full test report.

@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented Nov 27, 2023

Test report by @jfgrimm
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node041.viking2.yor.alces.network - Linux Rocky Linux 8.8, x86_64, AMD EPYC 7643 48-Core Processor, Python 3.6.8
See https://gist.github.com/jfgrimm/46b02830801c329bdb2b4d11b8dd9ac7 for a full test report.

Copy link
Copy Markdown
Member

@jfgrimm jfgrimm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented Nov 27, 2023

Going in, thanks @migueldiascosta!

@jfgrimm jfgrimm merged commit 264a60d into easybuilders:develop Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants