add patch for GCC 12.x to fix miscompiling C++ code causing double-free in case of exceptions by Flamefire · Pull Request #19253 · easybuilders/easybuild-easyconfigs

Flamefire · 2023-11-17T11:33:44Z

(created using eb --new-pr)

…ptions

schiotz · 2023-11-17T14:51:08Z

Test report by @schiotz
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
svol.fysik.dtu.dk - Linux CentOS Linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz, Python 3.6.8
See https://gist.github.com/schiotz/642662091a12c429fd7bf296a86a8181 for a full test report.

Flamefire · 2023-11-17T16:05:18Z

Test report by @Flamefire
SUCCESS
Build succeeded for 5 out of 5 (5 easyconfigs in total)
n1180 - Linux RHEL 8.7 (Ootpa), x86_64, Intel(R) Xeon(R) Platinum 8470 (icelake), Python 3.8.13
See https://gist.github.com/Flamefire/47e6aff5fa505e872307a00767924473 for a full test report.

Flamefire · 2023-11-17T19:24:42Z

Test report by @Flamefire
SUCCESS
Build succeeded for 5 out of 5 (5 easyconfigs in total)
taurusi8003 - Linux CentOS Linux 7.9.2009, x86_64, AMD EPYC 7352 24-Core Processor (zen2), 8 x NVIDIA NVIDIA A100-SXM4-40GB, 470.57.02, Python 2.7.5
See https://gist.github.com/Flamefire/608d4064dcfd84157f440a2a6a169fb3 for a full test report.

SebastianAchilles · 2023-11-18T01:10:31Z

Test report by @SebastianAchilles
SUCCESS
Build succeeded for 5 out of 5 (5 easyconfigs in total)
zen2-ubuntu-2310 - Linux Ubuntu 23.10 (Mantic Minotaur), x86_64, AMD EPYC 7452 32-Core Processor (zen2), Python 3.11.6
See https://gist.github.com/SebastianAchilles/fa4cfa3d81c0fdb1c9431867eb1e26c6 for a full test report.

SebastianAchilles · 2023-11-18T01:18:11Z

Test report by @SebastianAchilles
SUCCESS
Build succeeded for 5 out of 5 (5 easyconfigs in total)
skl-rockylinux-88 - Linux Rocky Linux 8.8, x86_64, Intel(R) Core(TM) i7-10700 CPU @ 2.90GHz (skylake), 1 x NVIDIA NVIDIA RTX A4000, 545.23.08, Python 3.6.8
See https://gist.github.com/SebastianAchilles/5332c9aa79cf0ced4a4af97774c90327 for a full test report.

schiotz · 2023-11-18T08:06:53Z

I can add to the test reports above that this actually fixed the issue that needed a workaround in PyTorch (in PR #19184).

Flamefire · 2023-11-18T10:56:50Z

I can add to the test reports above that this actually fixed the issue that needed a workaround in PyTorch (in PR #19184).

And I can confirm that the example C++ reproducer I created for GCC report works (only) after this :)

boegel · 2023-11-18T15:26:23Z

@boegelbot please test @ generoso
CORE_CNT=16

boegelbot · 2023-11-18T15:30:08Z

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=19253 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_19253 --ntasks="16" ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

exit code: 0
output:

Submitted batch job 12190

Test results coming soon (I hope)...

Details

- notification for comment with ID 1817537483 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

boegel · 2023-11-18T15:51:52Z

@boegelbot please test @ jsc-zen2
CORE_CNT=16

boegelbot · 2023-11-18T15:55:07Z

@boegel: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=19253 EB_ARGS= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --mem-per-cpu=4000M --job-name test_PR_19253 --ntasks="16" ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

exit code: 0
output:

Submitted batch job 3756

Test results coming soon (I hope)...

Details

- notification for comment with ID 1817543209 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

boegel

lgtm

boegelbot · 2023-11-18T19:26:14Z

Test report by @boegelbot
SUCCESS
Build succeeded for 5 out of 5 (5 easyconfigs in total)
jsczen2g1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/boegelbot/4abcaf46755a8a37fec11420fc2c20d7 for a full test report.

boegelbot · 2023-11-18T19:29:16Z

Test report by @boegelbot
SUCCESS
Build succeeded for 5 out of 5 (5 easyconfigs in total)
cnx1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/30fd963dd51044142a3c91d60ad3d3ca for a full test report.

boegel · 2023-11-18T19:49:13Z

Test report by @boegel
SUCCESS
Build succeeded for 5 out of 5 (5 easyconfigs in total)
node3120.skitty.os - Linux RHEL 8.8, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/boegel/53530f22ed08864b1116ccf8c25dbf41 for a full test report.

boegel · 2023-11-18T19:57:14Z

Going in, thanks @Flamefire!

fix GCC 12+ miscompiling C++ code causing double-free in case of exce…

9d28966

…ptions

This was referenced Nov 17, 2023

{ai}[foss/2022b] PyTorch v2.0.1 #19067

Merged

{ai}[foss/2022b] PyTorch v2.1.0 #19087

Closed

{tools}[foss/2023a] PyTorch v2.1.0, pytest-flakefinder v1.1.0, pytest-shard v0.1.2, ... #19184

Closed

schiotz added a commit to schiotz/easybuild-easyconfigs that referenced this pull request Nov 17, 2023

Remove workaround for GCCcore bug fixed in easybuilders#19253.

0453f71

SebastianAchilles added the bug fix label Nov 17, 2023

SebastianAchilles added this to the next release (4.9.0?) milestone Nov 17, 2023

boegel approved these changes Nov 18, 2023

View reviewed changes

boegel merged commit 97a3bc0 into easybuilders:develop Nov 18, 2023

Flamefire deleted the 20231117123340_new_pr_GCCcore1010 branch November 19, 2023 11:01

boegel changed the title ~~fix GCC 12+ miscompiling C++ code causing double-free in case of exceptions~~ add patch for GCC 12.x to fix miscompiling C++ code causing double-free in case of exceptions Nov 22, 2023

Conversation

Flamefire commented Nov 17, 2023

Uh oh!

schiotz commented Nov 17, 2023

Uh oh!

Flamefire commented Nov 17, 2023

Uh oh!

Flamefire commented Nov 17, 2023

Uh oh!

SebastianAchilles commented Nov 18, 2023

Uh oh!

SebastianAchilles commented Nov 18, 2023

Uh oh!

schiotz commented Nov 18, 2023

Uh oh!

Flamefire commented Nov 18, 2023

Uh oh!

boegel commented Nov 18, 2023

Uh oh!

boegelbot commented Nov 18, 2023

Uh oh!

boegel commented Nov 18, 2023

Uh oh!

boegelbot commented Nov 18, 2023

Uh oh!

boegel left a comment

Choose a reason for hiding this comment

Uh oh!

boegelbot commented Nov 18, 2023

Uh oh!

boegelbot commented Nov 18, 2023

Uh oh!

boegel commented Nov 18, 2023

Uh oh!

boegel commented Nov 18, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants