Skip to content

replace format tag with explicit extension name in Optuna v3.0.3#19256

Merged
smoors merged 1 commit intoeasybuilders:developfrom
lexming:20231117194227_new_pr_Optuna310
Nov 18, 2023
Merged

replace format tag with explicit extension name in Optuna v3.0.3#19256
smoors merged 1 commit intoeasybuilders:developfrom
lexming:20231117194227_new_pr_Optuna310

Conversation

@lexming
Copy link
Copy Markdown
Contributor

@lexming lexming commented Nov 17, 2023

ERROR: Traceback (most recent call last):
  File "/scratch/brussel/vo/000/bvo00005/vsc10001/easybuild-framework/easybuild/main.py", line 135, in build_and_install_software
    (ec_res['success'], app_log, err) = build_and_install_one(ec, init_env)
  File "/scratch/brussel/vo/000/bvo00005/vsc10001/easybuild-framework/easybuild/framework/easyblock.py", line 4256, in build_and_install_one
    result = app.run_all_steps(run_test_cases=run_test_cases)
  File "/scratch/brussel/vo/000/bvo00005/vsc10001/easybuild-framework/easybuild/framework/easyblock.py", line 4135, in run_all_steps
    self.run_step(step_name, step_methods)
  File "/scratch/brussel/vo/000/bvo00005/vsc10001/easybuild-framework/easybuild/framework/easyblock.py", line 3970, in run_step
    step_method(self)()
  File "/scratch/brussel/vo/000/bvo00005/vsc10001/easybuild-easyblocks/easybuild/easyblocks/generic/pythonbundle.py", line 125, in extensions_step
    super(PythonBundle, self).extensions_step(*args, **kwargs)
  File "/scratch/brussel/vo/000/bvo00005/vsc10001/easybuild-framework/easybuild/framework/easyblock.py", line 2872, in extensions_step
    fake_mod_data = self.load_fake_module(purge=True, extra_modules=build_dep_mods)
  File "/scratch/brussel/vo/000/bvo00005/vsc10001/easybuild-framework/easybuild/framework/easyblock.py", line 1700, in load_fake_module
    fake_mod_path = self.make_module_step(fake=True)
  File "/scratch/brussel/vo/000/bvo00005/vsc10001/easybuild-framework/easybuild/framework/easyblock.py", line 3737, in make_module_step
    txt += self.make_module_description()
  File "/scratch/brussel/vo/000/bvo00005/vsc10001/easybuild-framework/easybuild/framework/easyblock.py", line 1382, in make_module_description
    return self.module_generator.get_description()
  File "/scratch/brussel/vo/000/bvo00005/vsc10001/easybuild-framework/easybuild/tools/module_generator.py", line 1303, in get_description
    'homepage': self.app.cfg['homepage'],
KeyError: 'namelower'

@smoors
Copy link
Copy Markdown
Contributor

smoors commented Nov 18, 2023

@boegelbot: please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

@smoors: Request for testing this PR well received on login1

PR test command 'EB_PR=19256 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_19256 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 12187

Test results coming soon (I hope)...

Details

- notification for comment with ID 1817446957 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns3 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/1c222da2dd1b704aa8a17b833de2ee27 for a full test report.

@smoors
Copy link
Copy Markdown
Contributor

smoors commented Nov 18, 2023

@boegelbot please test @ jsc-zen2

@boegelbot
Copy link
Copy Markdown
Collaborator

@smoors: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=19256 EB_ARGS= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --mem-per-cpu=4000M --job-name test_PR_19256 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 3753

Test results coming soon (I hope)...

Details

- notification for comment with ID 1817448096 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/boegelbot/40c84e3183d8ea5a2b1c77ce6e4612bb for a full test report.

Copy link
Copy Markdown
Contributor

@smoors smoors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smoors smoors added this to the next release (4.9.0?) milestone Nov 18, 2023
@smoors
Copy link
Copy Markdown
Contributor

smoors commented Nov 18, 2023

Going in, thanks @lexming!

@smoors smoors merged commit 3887714 into easybuilders:develop Nov 18, 2023
@lexming lexming deleted the 20231117194227_new_pr_Optuna310 branch November 29, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants