Skip to content

avoid indirect dependency on old CMake version built with GCCcore/10.2.0 via Catch2 build dependency using system toolchain in recent pybind11 easyconfigs#19270

Merged
verdurin merged 1 commit intoeasybuilders:developfrom
boegel:20231120202513_new_pr_pybind112103
Nov 21, 2023
Merged

avoid indirect dependency on old CMake version built with GCCcore/10.2.0 via Catch2 build dependency using system toolchain in recent pybind11 easyconfigs#19270
verdurin merged 1 commit intoeasybuilders:developfrom
boegel:20231120202513_new_pr_pybind112103

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Nov 20, 2023 •
edited
Loading

(created using eb --new-pr)

Catch2-2.13.9.eb has a hardcoded dependency on CMake/3.18.4-GCCcore-10.2.0, so when building something in the 2023a easyconfigs generation that requires pybind11, we first need to build GCCcore/10.2.0.
That's just backwards, and it causes trouble on recent OSs like Ubuntu 22.04

The proposed changes basically make Catch2 use a proper toolchain, just like we also started doing for Eigen (cfr. PR #10098), largely for the same reasons...

@boegel boegel added this to the next release (4.9.0?) milestone Nov 20, 2023
@boegel boegel mentioned this pull request Nov 21, 2023
Merged
@boegel
avoid indirect dependency on old CMake version built with GCCcore/10.…
fb88533 
…2.0 via Catch2 build dependency using system toolchain in recent pybind11 easyconfigs
@boegel boegel force-pushed the 20231120202513_new_pr_pybind112103 branch from 0cb184d to fb88533 Compare November 21, 2023 06:51
@easybuilders easybuilders deleted a comment from boegelbot Nov 21, 2023
@easybuilders easybuilders deleted a comment from boegelbot Nov 21, 2023
@easybuilders easybuilders deleted a comment from boegelbot Nov 21, 2023
@easybuilders easybuilders deleted a comment from boegelbot Nov 21, 2023
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Nov 21, 2023

@boegelbot please test @ jsc-zen2

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Nov 21, 2023

@boegel: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=19270 EB_ARGS= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --mem-per-cpu=4000M --job-name test_PR_19270 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 3766

Test results coming soon (I hope)...

Details

- notification for comment with ID 1820335365 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Nov 21, 2023

Test report by @boegel
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in total)
node3144.skitty.os - Linux RHEL 8.8, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/boegel/5145fd912f14b6056d210d71583aee2d for a full test report.

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Nov 21, 2023

Test report by @boegelbot
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/boegelbot/5ecb047dbbdc0d9824eace3e2dfe1cec for a full test report.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Nov 21, 2023

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Nov 21, 2023

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=19270 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_19270 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 12198

Test results coming soon (I hope)...

Details

- notification for comment with ID 1820381269 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Nov 21, 2023

Test report by @boegelbot
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in total)
cns3 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/ccd3b06a48ac882be0efc4218ecd720c for a full test report.

@verdurin
Copy link
Copy Markdown
Member

verdurin commented Nov 21, 2023

Test report by @verdurin
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in total)
easybuild-c7.novalocal - Linux CentOS Linux 7.9.2009, x86_64, Intel Xeon Processor (Skylake, IBRS), Python 3.6.8
See https://gist.github.com/verdurin/62c65958be0c8daaced2e09f307d7968 for a full test report.

@verdurin
Copy link
Copy Markdown
Member

verdurin commented Nov 21, 2023

@boegelbot please test @ jsc-zen2

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Nov 21, 2023

@verdurin: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=19270 EB_ARGS= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --mem-per-cpu=4000M --job-name test_PR_19270 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 3773

Test results coming soon (I hope)...

Details

- notification for comment with ID 1820848678 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Nov 21, 2023

Test report by @boegelbot
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/boegelbot/b6063f8ab6a5adbf713cf2dab90b31c0 for a full test report.

verdurin
verdurin approved these changes Nov 21, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@verdurin verdurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

@verdurin
Copy link
Copy Markdown
Member

verdurin commented Nov 21, 2023

Going in, thanks @boegel!

@verdurin verdurin merged commit a251edc into easybuilders:develop Nov 21, 2023
@boegel boegel deleted the 20231120202513_new_pr_pybind112103 branch November 22, 2023 06:30
This was referenced Nov 22, 2023
Closed
Merged
@boegel boegel mentioned this pull request Jan 11, 2024
Closed
@boegel boegel mentioned this pull request Jan 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@verdurin verdurin verdurin approved these changes

Assignees

No one assigned

Labels

bug fix change

Projects

None yet

Milestone

4.9.0

Development

Successfully merging this pull request may close these issues.

3 participants

@boegel @boegelbot @verdurin