Skip to content

add versionsuffix -param to ReaxFF and add -sim variant#19307

Merged
SebastianAchilles merged 5 commits intoeasybuilders:developfrom
smoors:20231123162044_new_pr_ReaxFF20
Dec 27, 2023
Merged

add versionsuffix -param to ReaxFF and add -sim variant#19307
SebastianAchilles merged 5 commits intoeasybuilders:developfrom
smoors:20231123162044_new_pr_ReaxFF20

Conversation

@smoors
Copy link
Copy Markdown
Contributor

@smoors smoors commented Nov 23, 2023

(created using eb --new-pr)

@smoors smoors added the update label Nov 23, 2023
@smoors
Copy link
Copy Markdown
Contributor Author

smoors commented Nov 23, 2023

Test report by @smoors
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
node300.hydra.os - Linux CentOS Linux 7.9.2009, x86_64, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/smoors/577af0bf49565754cb7a69b46d46f10d for a full test report.

@verdurin
Copy link
Copy Markdown
Member

@smoors could you add a comment explaining this one a bit more?

@smoors
Copy link
Copy Markdown
Contributor Author

smoors commented Nov 27, 2023

@smoors could you add a comment explaining this one a bit more?

there are 2 variants of this code: the parameter and the simulation variant.
the parameter variant generates the parameters, the simulation variant runs the simulation.
the annoying thing here is that both have the same executable name.

i changed the name of ReaxFF-param to ReaxFF and added the -param versionsuffix,
and also added another ReaxFF module with the -sim versionsuffix.
this way we prevent both modules to be loaded at the same time, so it's always clear which executable is used.

@jfgrimm jfgrimm added the change label Nov 28, 2023
@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented Nov 28, 2023

@smoors could you add a comment explaining this one a bit more?

there are 2 variants of this code: the parameter and the simulation variant. the parameter variant generates the parameters, the simulation variant runs the simulation. the annoying thing here is that both have the same executable name.

i changed the name of ReaxFF-param to ReaxFF and added the -param versionsuffix, and also added another ReaxFF module with the -sim versionsuffix. this way we prevent both modules to be loaded at the same time, so it's always clear which executable is used.

that's fair; might be worth adding a brief comment to the easyconfigs making it clear that you're intentionally using a versionsuffix to prevent loading both

@jfgrimm

This comment was marked as outdated.

Copy link
Copy Markdown
Contributor

@lexming lexming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lexming lexming added this to the next release (4.9.0?) milestone Dec 8, 2023
@lexming
Copy link
Copy Markdown
Contributor

lexming commented Dec 8, 2023

Going in, thanks @smoors !

@SebastianAchilles
Copy link
Copy Markdown
Member

Going in, thanks @smoors!

@SebastianAchilles SebastianAchilles merged commit d3543c2 into easybuilders:develop Dec 27, 2023
@boegel boegel changed the title add versionsuffix -param to reaxff and add -sim variant add versionsuffix -param to ReaxFF and add -sim variant Dec 30, 2023
@smoors smoors deleted the 20231123162044_new_pr_ReaxFF20 branch January 15, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants