Skip to content

don't use %(namelower)s template in extension name in IPython v8.14.0 easyconfig#19330

Merged
boegel merged 1 commit intoeasybuilders:developfrom
Micket:20231128100313_new_pr_IPython8140
Dec 26, 2023
Merged

don't use %(namelower)s template in extension name in IPython v8.14.0 easyconfig#19330
boegel merged 1 commit intoeasybuilders:developfrom
Micket:20231128100313_new_pr_IPython8140

Conversation

@Micket
Copy link
Copy Markdown
Contributor

@Micket Micket commented Nov 28, 2023

(created using eb --new-pr)

@branfosj branfosj mentioned this pull request Nov 28, 2023
Merged
@verdurin
Copy link
Copy Markdown
Member

verdurin commented Dec 14, 2023

Test report by @verdurin
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
easybuild-c7.novalocal - Linux CentOS Linux 7.9.2009, x86_64, Intel Xeon Processor (Skylake, IBRS), Python 3.6.8
See https://gist.github.com/verdurin/0d6f6073187a8d00f5b6604e194e8fe6 for a full test report.

@verdurin verdurin added this to the next release (4.9.0?) milestone Dec 14, 2023
@verdurin
Copy link
Copy Markdown
Member

verdurin commented Dec 14, 2023

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Dec 14, 2023

@verdurin: Request for testing this PR well received on login1

PR test command 'EB_PR=19330 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_19330 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 12403

Test results coming soon (I hope)...

Details

- notification for comment with ID 1855736528 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Dec 14, 2023

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns2 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/a9daf21ad696b8a87f3107354faba3a5 for a full test report.

@boegel boegel changed the title Fix bugged use of namelower in extension name fix bugged use of %(namelower)s template in extension name in IPython v8.14.0 easyconfig Dec 26, 2023
@boegel boegel changed the title fix bugged use of %(namelower)s template in extension name in IPython v8.14.0 easyconfig don't use %(namelower)s template in extension name in IPython v8.14.0 easyconfig Dec 26, 2023
@boegel
Copy link
Copy Markdown
Member

boegel commented Dec 26, 2023

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3114.skitty.os - Linux RHEL 8.8, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/boegel/6ca950bd5183b9af126b3575b95c52b6 for a full test report.

boegel
boegel approved these changes Dec 26, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Copy Markdown
Member

boegel commented Dec 26, 2023

Going in, thanks @Micket!

@boegel boegel merged commit 5a3d37c into easybuilders:develop Dec 26, 2023
@Micket Micket deleted the 20231128100313_new_pr_IPython8140 branch April 7, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.9.0

Development

Successfully merging this pull request may close these issues.

4 participants

@Micket @verdurin @boegelbot @boegel