Skip to content

Fix failing tokenizers with CargoPythonPackage easyblock#19333

Merged
jfgrimm merged 3 commits intoeasybuilders:developfrom
Micket:20231128211908_new_pr_tokenizers0133
Nov 29, 2023
Merged

Fix failing tokenizers with CargoPythonPackage easyblock#19333
jfgrimm merged 3 commits intoeasybuilders:developfrom
Micket:20231128211908_new_pr_tokenizers0133

Conversation

@Micket
Copy link
Copy Markdown
Contributor

@Micket Micket commented Nov 28, 2023

(created using eb --new-pr)

@Micket
Copy link
Copy Markdown
Contributor Author

Micket commented Nov 28, 2023 •
edited
Loading

Test report by @Micket
FAILED
Build succeeded for 0 out of 1 (1 easyconfigs in total)
vera-skylake-build - Linux Rocky Linux 8.8, x86_64, Intel Xeon Processor (Skylake, IBRS, no TSX), Python 3.6.8
See https://gist.github.com/Micket/7cbaa9683f1f4e6dbb93788226f96fee for a full test report.

This was failing because it was still missing at least some crates

@Micket Micket added this to the next release (4.9.0?) milestone Nov 28, 2023
@Micket Micket added the bug fix label Nov 28, 2023
@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented Nov 29, 2023

Test report by @jfgrimm
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node041.viking2.yor.alces.network - Linux Rocky Linux 8.8, x86_64, AMD EPYC 7643 48-Core Processor, Python 3.6.8
See https://gist.github.com/jfgrimm/d761ed8cf7a264cfc15005997db14521 for a full test report.

@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented Nov 29, 2023

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Nov 29, 2023

@jfgrimm: Request for testing this PR well received on login1

PR test command 'EB_PR=19333 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_19333 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 12301

Test results coming soon (I hope)...

Details

- notification for comment with ID 1831806987 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented Nov 29, 2023

@boegelbot please test @ jsc-zen2

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Nov 29, 2023

@jfgrimm: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=19333 EB_ARGS= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --mem-per-cpu=4000M --job-name test_PR_19333 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 3828

Test results coming soon (I hope)...

Details

- notification for comment with ID 1831823865 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Nov 29, 2023

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns3 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/5aa3b3fd06f307e55e3c810cadadc1c2 for a full test report.

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Nov 29, 2023

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/boegelbot/30b38b5b0e7574aa88a4686f79b4e31e for a full test report.

jfgrimm
jfgrimm approved these changes Nov 29, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@jfgrimm jfgrimm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented Nov 29, 2023

Going in, thanks @Micket!

@jfgrimm jfgrimm merged commit 389c406 into easybuilders:develop Nov 29, 2023
@Micket Micket deleted the 20231128211908_new_pr_tokenizers0133 branch November 29, 2023 21:49
@boegel boegel changed the title Fix failing tokenizers with cargopythonpackage Fix failing tokenizers with CargoPythonPackage easyblock Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jfgrimm jfgrimm jfgrimm approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.9.0

Development

Successfully merging this pull request may close these issues.

3 participants

@Micket @jfgrimm @boegelbot