Skip to content

{geo}[gompi/2021b] BiasAdjustCXX v1.9.1#19341

Merged
smoors merged 6 commits intoeasybuilders:developfrom
TopRichard:20231130234824_new_pr_BiasAdjustCXX191
Dec 28, 2023
Merged

{geo}[gompi/2021b] BiasAdjustCXX v1.9.1#19341
smoors merged 6 commits intoeasybuilders:developfrom
TopRichard:20231130234824_new_pr_BiasAdjustCXX191

Conversation

@TopRichard
Copy link
Copy Markdown
Contributor

(created using eb --new-pr)

@jfgrimm jfgrimm added the new label Dec 2, 2023
@jfgrimm jfgrimm added this to the 4.x milestone Dec 2, 2023
@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented Dec 2, 2023

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

@jfgrimm: Request for testing this PR well received on login1

PR test command 'EB_PR=19341 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_19341 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 12319

Test results coming soon (I hope)...

Details

- notification for comment with ID 1837174429 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
FAILED
Build succeeded for 0 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/e0c1094a1e1f87968e4712bc95561d5e for a full test report.

@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented Dec 2, 2023

== 2023-12-02 15:10:50,746 easyblock.py:4277 WARNING build failed (first 300 chars): Failed to determine CMake version from output of 'cmake --version': /bin/bash: cmake: command not found

jfgrimm
jfgrimm previously requested changes Dec 2, 2023
@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented Dec 3, 2023

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

@jfgrimm: Request for testing this PR well received on login1

PR test command 'EB_PR=19341 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_19341 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 12321

Test results coming soon (I hope)...

Details

- notification for comment with ID 1837481100 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
FAILED
Build succeeded for 0 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/4c1f3d2d13be3f57b1877756ee3968da for a full test report.

Went down from foss to gompi, and from NCO to netCDF-C++4
@TopRichard TopRichard changed the title {geo}[foss/2021b] BiasAdjustCXX v1.9.1 {geo}[gompi/2021b] BiasAdjustCXX v1.9.1 Dec 4, 2023
Copy link
Copy Markdown
Contributor Author

@TopRichard TopRichard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also modified toolchain and dependency list.

@boegelbot

This comment was marked as resolved.

@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented Dec 5, 2023

@TopRichard I've pushed a change that renames the easyconfig to reflect the toolchain change

@smoors
Copy link
Copy Markdown
Contributor

smoors commented Dec 27, 2023

@boegelbot: please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

@smoors: Request for testing this PR well received on login1

PR test command 'EB_PR=19341 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_19341 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 12467

Test results coming soon (I hope)...

Details

- notification for comment with ID 1870627023 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
FAILED
Build succeeded for 0 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/2532560ca5fdbefd391832025c9aff68 for a full test report.

@smoors
Copy link
Copy Markdown
Contributor

smoors commented Dec 27, 2023

CMakeFiles/BiasAdjustCXX.dir/Manager.cxx.o:Manager.cxx:function Manager::adjust_3d(std::vector<std::vector<std::vector<float, std::allocator >, std::allocator<std::vector<float, std::allocator > > >, std::allocator<std::vector<std::vector<float, std::allocator >, std::allocator<std::vector<float, std::allocator > > > > >&): error: undefined reference to 'pthread_create'

Comment thread easybuild/easyconfigs/b/BiasAdjustCXX/BiasAdjustCXX-1.9.1-gompi-2021b.eb Outdated
@smoors
Copy link
Copy Markdown
Contributor

smoors commented Dec 28, 2023

@boegelbot: please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

@smoors: Request for testing this PR well received on login1

PR test command 'EB_PR=19341 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_19341 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 12469

Test results coming soon (I hope)...

Details

- notification for comment with ID 1870935164 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/b32041bf35b6f79e0191ec271d809048 for a full test report.

@smoors
Copy link
Copy Markdown
Contributor

smoors commented Dec 28, 2023

@boegelbot please test @ jsc-zen2

@boegelbot
Copy link
Copy Markdown
Collaborator

@smoors: Request for testing this PR well received on jsczen2l1.int.jsc-zen2.easybuild-test.cluster

PR test command 'EB_PR=19341 EB_ARGS= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --mem-per-cpu=4000M --job-name test_PR_19341 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen2.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 3968

Test results coming soon (I hope)...

Details

- notification for comment with ID 1870944158 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (1 easyconfigs in total)
jsczen2c1.int.jsc-zen2.easybuild-test.cluster - Linux Rocky Linux 8.5, x86_64, AMD EPYC 7742 64-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/boegelbot/77131f926f086a358096fe2bcbf26903 for a full test report.

@smoors smoors modified the milestones: 4.x, next release (4.9.0?) Dec 28, 2023
Copy link
Copy Markdown
Contributor

@smoors smoors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smoors smoors dismissed jfgrimm’s stale review December 28, 2023 09:00

requested changes done

@smoors
Copy link
Copy Markdown
Contributor

smoors commented Dec 28, 2023

Going in, thanks @TopRichard!

@smoors smoors merged commit d167f45 into easybuilders:develop Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants