allow Python version of Z3 to be used as a dependency#19354
Merged
branfosj merged 2 commits intoeasybuilders:developfrom Dec 14, 2023
Merged
allow Python version of Z3 to be used as a dependency#19354branfosj merged 2 commits intoeasybuilders:developfrom
branfosj merged 2 commits intoeasybuilders:developfrom
Conversation
Remove the C&P code for filtering a dep_var with a specific version_suffix if exactly 1 match was found. Replace by a list similar to `multiple_allowed_variants` and the code to directly delete the key instead of rebuilding the dict. Also assert only once with all found issues. Allows easier extension.
`test_dep_versions_per_toolchain_generation` fails because the versions with and without Python-bindings are used.
This was referenced Dec 5, 2023
branfosj
approved these changes
Dec 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_dep_versions_per_toolchain_generationfails because the versions with and without Python-bindings can be used as dependencies.I extracted the refactoring to #19355 in case that needs discussion. Otherwise we can just merge this Pr which closes #19355
cc @lexming @branfosj as this change is required after adding the ECs in #18284