use new DualSPHysics easyblock by jfgrimm · Pull Request #19400 · easybuilders/easybuild-easyconfigs

jfgrimm · 2023-12-12T11:32:35Z

requires:

new easyblock for DualSPHysics easybuild-easyblocks#3050

When building with EasyBuild configured to use rpath, the sanity checks for the existing easyconfig fail because some prebuilt binaries and libraries are bundled in the tarball, and these don't have an RPATH section. The new easyblock runs patchelf to add a corresponding entry.

(created using eb --new-pr)

jfgrimm · 2023-12-12T11:49:27Z

Test report by @jfgrimm
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#3050
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node030.viking2.yor.alces.network - Linux Rocky Linux 8.8, x86_64, AMD EPYC 7643 48-Core Processor, Python 3.6.8
See https://gist.github.com/jfgrimm/854a04c4dfaf6e552abd9334c677388b for a full test report.

boegelbot · 2023-12-12T12:26:15Z

@jfgrimm: Tests failed in GitHub Actions, see https://github.com/easybuilders/easybuild-easyconfigs/actions/runs/7180841959
Last 100 lines of output from first failing test suite run:

  File "/home/runner/work/easybuild-easyconfigs/easybuild-easyconfigs/test/easyconfigs/easyconfigs.py", line 250, in _get_changed_easyconfigs
    ec = process_easyconfig(ec_file)
  File "/opt/hostedtoolcache/Python/3.6.15/x64/lib/python3.6/site-packages/easybuild/framework/easyconfig/easyconfig.py", line 2087, in process_easyconfig
    raise EasyBuildError("Failed to process easyconfig %s: %s", spec, err.msg)
easybuild.tools.build_log.EasyBuildError: "Failed to process easyconfig /home/runner/work/easybuild-easyconfigs/easybuild-easyconfigs/easybuild/easyconfigs/d/DualSPHysics/DualSPHysics-5.0.175-GCC-11.2.0.eb: No software-specific easyblock 'EB_DualSPHysics' found for DualSPHysics"

======================================================================
ERROR: test_r_libs_site_env_var (test.easyconfigs.easyconfigs.EasyConfigTest)
Make sure $R_LIBS_SITE is being updated, rather than $R_LIBS.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/opt/hostedtoolcache/Python/3.6.15/x64/lib/python3.6/site-packages/easybuild/tools/utilities.py", line 236, in get_class_for
    module = __import__(modulepath, globals(), locals(), [''])
ModuleNotFoundError: No module named 'easybuild.easyblocks.dualsphysics'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/opt/hostedtoolcache/Python/3.6.15/x64/lib/python3.6/site-packages/easybuild/framework/easyconfig/easyconfig.py", line 1937, in get_easyblock_class
    cls = get_class_for(modulepath, class_name)
  File "/opt/hostedtoolcache/Python/3.6.15/x64/lib/python3.6/site-packages/easybuild/tools/utilities.py", line 238, in get_class_for
    raise ImportError(err)
ImportError: No module named 'easybuild.easyblocks.dualsphysics'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/opt/hostedtoolcache/Python/3.6.15/x64/lib/python3.6/site-packages/easybuild/framework/easyconfig/easyconfig.py", line 2085, in process_easyconfig
    ec = EasyConfig(spec, build_specs=build_specs, validate=validate, hidden=hidden)
  File "/opt/hostedtoolcache/Python/3.6.15/x64/lib/python3.6/site-packages/easybuild/framework/easyconfig/easyconfig.py", line 482, in __init__
    easyblock_class = get_easyblock_class(self.easyblock, name=self.software_name)
  File "/opt/hostedtoolcache/Python/3.6.15/x64/lib/python3.6/site-packages/easybuild/framework/easyconfig/easyconfig.py", line 1963, in get_easyblock_class
    raise err
  File "/opt/hostedtoolcache/Python/3.6.15/x64/lib/python3.6/site-packages/easybuild/framework/easyconfig/easyconfig.py", line 1947, in get_easyblock_class
    raise EasyBuildError("No software-specific easyblock '%s' found for %s", class_name, name)
easybuild.tools.build_log.EasyBuildError: "No software-specific easyblock 'EB_DualSPHysics' found for DualSPHysics"

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/runner/work/easybuild-easyconfigs/easybuild-easyconfigs/test/easyconfigs/easyconfigs.py", line 919, in test_r_libs_site_env_var
    for ec in self.parsed_easyconfigs:
  File "/home/runner/work/easybuild-easyconfigs/easybuild-easyconfigs/test/easyconfigs/easyconfigs.py", line 276, in parsed_easyconfigs
    EasyConfigTest.parse_all_easyconfigs()
  File "/home/runner/work/easybuild-easyconfigs/easybuild-easyconfigs/test/easyconfigs/easyconfigs.py", line 201, in parse_all_easyconfigs
    cls._parsed_easyconfigs.extend(process_easyconfig(spec))
  File "/opt/hostedtoolcache/Python/3.6.15/x64/lib/python3.6/site-packages/easybuild/framework/easyconfig/easyconfig.py", line 2087, in process_easyconfig
    raise EasyBuildError("Failed to process easyconfig %s: %s", spec, err.msg)
easybuild.tools.build_log.EasyBuildError: "Failed to process easyconfig /home/runner/work/easybuild-easyconfigs/easybuild-easyconfigs/easybuild/easyconfigs/d/DualSPHysics/DualSPHysics-5.0.175-GCC-11.2.0.eb: No software-specific easyblock 'EB_DualSPHysics' found for DualSPHysics"

======================================================================
ERROR: test_sanity_check_paths (test.easyconfigs.easyconfigs.EasyConfigTest)
Make sure specified sanity check paths adher to the requirements.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/opt/hostedtoolcache/Python/3.6.15/x64/lib/python3.6/site-packages/easybuild/tools/utilities.py", line 236, in get_class_for
    module = __import__(modulepath, globals(), locals(), [''])
ModuleNotFoundError: No module named 'easybuild.easyblocks.dualsphysics'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/opt/hostedtoolcache/Python/3.6.15/x64/lib/python3.6/site-packages/easybuild/framework/easyconfig/easyconfig.py", line 1937, in get_easyblock_class
    cls = get_class_for(modulepath, class_name)
  File "/opt/hostedtoolcache/Python/3.6.15/x64/lib/python3.6/site-packages/easybuild/tools/utilities.py", line 238, in get_class_for
    raise ImportError(err)
ImportError: No module named 'easybuild.easyblocks.dualsphysics'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/opt/hostedtoolcache/Python/3.6.15/x64/lib/python3.6/site-packages/easybuild/framework/easyconfig/easyconfig.py", line 2085, in process_easyconfig
    ec = EasyConfig(spec, build_specs=build_specs, validate=validate, hidden=hidden)
  File "/opt/hostedtoolcache/Python/3.6.15/x64/lib/python3.6/site-packages/easybuild/framework/easyconfig/easyconfig.py", line 482, in __init__
    easyblock_class = get_easyblock_class(self.easyblock, name=self.software_name)
  File "/opt/hostedtoolcache/Python/3.6.15/x64/lib/python3.6/site-packages/easybuild/framework/easyconfig/easyconfig.py", line 1963, in get_easyblock_class
    raise err
  File "/opt/hostedtoolcache/Python/3.6.15/x64/lib/python3.6/site-packages/easybuild/framework/easyconfig/easyconfig.py", line 1947, in get_easyblock_class
    raise EasyBuildError("No software-specific easyblock '%s' found for %s", class_name, name)
easybuild.tools.build_log.EasyBuildError: "No software-specific easyblock 'EB_DualSPHysics' found for DualSPHysics"

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/runner/work/easybuild-easyconfigs/easybuild-easyconfigs/test/easyconfigs/easyconfigs.py", line 903, in test_sanity_check_paths
    for ec in self.parsed_easyconfigs:
  File "/home/runner/work/easybuild-easyconfigs/easybuild-easyconfigs/test/easyconfigs/easyconfigs.py", line 276, in parsed_easyconfigs
    EasyConfigTest.parse_all_easyconfigs()
  File "/home/runner/work/easybuild-easyconfigs/easybuild-easyconfigs/test/easyconfigs/easyconfigs.py", line 201, in parse_all_easyconfigs
    cls._parsed_easyconfigs.extend(process_easyconfig(spec))
  File "/opt/hostedtoolcache/Python/3.6.15/x64/lib/python3.6/site-packages/easybuild/framework/easyconfig/easyconfig.py", line 2087, in process_easyconfig
    raise EasyBuildError("Failed to process easyconfig %s: %s", spec, err.msg)
easybuild.tools.build_log.EasyBuildError: "Failed to process easyconfig /home/runner/work/easybuild-easyconfigs/easybuild-easyconfigs/easybuild/easyconfigs/d/DualSPHysics/DualSPHysics-5.0.175-GCC-11.2.0.eb: No software-specific easyblock 'EB_DualSPHysics' found for DualSPHysics"

----------------------------------------------------------------------
Ran 18644 tests in 531.729s

FAILED (errors=12)
ERROR: Not all tests were successful

bleep, bloop, I'm just a bot (boegelbot v20200716.01)
Please talk to my owner @boegel if you notice me acting stupid),
or submit a pull request to https://github.com/boegel/boegelbot fix the problem.

jfgrimm · 2024-01-04T15:55:59Z

Test report by @jfgrimm
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#3050
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node099.viking2.yor.alces.network - Linux Rocky Linux 8.8, x86_64, AMD EPYC 7643 48-Core Processor, Python 3.6.8
See https://gist.github.com/jfgrimm/44b940c660ae2a387e618962409e7c9e for a full test report.

…asyconfigs into 20231212113228_new_pr_DualSPHysics50175

akesandgren · 2024-01-08T09:06:21Z

@boegelbot Please test @ generoso

boegelbot · 2024-01-08T09:10:08Z

@akesandgren: Request for testing this PR well received on login1

PR test command 'EB_PR=19400 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_19400 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

exit code: 0
output:

Submitted batch job 12533

Test results coming soon (I hope)...

Details

- notification for comment with ID 1880611258 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

boegelbot · 2024-01-08T09:11:45Z

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/fc941a1644555fda1416bd0dc494a79b for a full test report.

akesandgren · 2024-01-08T09:14:28Z

@boegelbot Please test @ generoso
EB_ARGS='--rpath --rebuild'

boegelbot · 2024-01-08T09:15:05Z

@akesandgren: Request for testing this PR well received on login1

PR test command 'EB_PR=19400 EB_ARGS="--rpath --rebuild" EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_19400 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

exit code: 0
output:

Submitted batch job 12534

Test results coming soon (I hope)...

Details

- notification for comment with ID 1880622890 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

boegelbot · 2024-01-08T09:16:48Z

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/84f7562db4154e7a07d7152195f0329b for a full test report.

akesandgren

LGTM

akesandgren · 2024-01-08T09:21:08Z

Going in, thanks @jfgrimm!

use new DualSPHysics easyblock

484dd1e

jfgrimm added the bug fix label Dec 12, 2023

jfgrimm added this to the 4.x milestone Dec 12, 2023

jfgrimm mentioned this pull request Dec 12, 2023

new easyblock for DualSPHysics easybuilders/easybuild-easyblocks#3050

Merged

Merge branch 'develop' of https://github.com/easybuilders/easybuild-e…

e85538f

…asyconfigs into 20231212113228_new_pr_DualSPHysics50175

akesandgren approved these changes Jan 8, 2024

View reviewed changes

akesandgren modified the milestones: 4.x, release after 4.9.0 Jan 8, 2024

akesandgren merged commit e852c1e into easybuilders:develop Jan 8, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

use new DualSPHysics easyblock#19400

use new DualSPHysics easyblock#19400
akesandgren merged 2 commits intoeasybuilders:developfrom
jfgrimm:20231212113228_new_pr_DualSPHysics50175

jfgrimm commented Dec 12, 2023 •

edited by akesandgren

Loading

Uh oh!

jfgrimm commented Dec 12, 2023

Uh oh!

boegelbot commented Dec 12, 2023

Uh oh!

jfgrimm commented Jan 4, 2024

Uh oh!

akesandgren commented Jan 8, 2024

Uh oh!

boegelbot commented Jan 8, 2024

Uh oh!

boegelbot commented Jan 8, 2024

Uh oh!

akesandgren commented Jan 8, 2024

Uh oh!

boegelbot commented Jan 8, 2024

Uh oh!

boegelbot commented Jan 8, 2024

Uh oh!

akesandgren left a comment

Uh oh!

akesandgren commented Jan 8, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

jfgrimm commented Dec 12, 2023 • edited by akesandgren Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jfgrimm commented Dec 12, 2023

Uh oh!

boegelbot commented Dec 12, 2023

Uh oh!

jfgrimm commented Jan 4, 2024

Uh oh!

akesandgren commented Jan 8, 2024

Uh oh!

boegelbot commented Jan 8, 2024

Uh oh!

boegelbot commented Jan 8, 2024

Uh oh!

akesandgren commented Jan 8, 2024

Uh oh!

boegelbot commented Jan 8, 2024

Uh oh!

boegelbot commented Jan 8, 2024

Uh oh!

akesandgren left a comment

Choose a reason for hiding this comment

Uh oh!

akesandgren commented Jan 8, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

jfgrimm commented Dec 12, 2023 •

edited by akesandgren

Loading