Skip to content

{cae}[foss/2022b] Elmer v9.0#19448

Merged
ocaisa merged 8 commits intoeasybuilders:developfrom
kosl:20231220172202_new_pr_Elmer90
Jan 25, 2024
Merged

{cae}[foss/2022b] Elmer v9.0#19448
ocaisa merged 8 commits intoeasybuilders:developfrom
kosl:20231220172202_new_pr_Elmer90

Conversation

@kosl
Copy link
Copy Markdown
Contributor

@kosl kosl commented Dec 20, 2023

(created using eb --new-pr)

Comment thread easybuild/easyconfigs/e/Elmer/Elmer-9.0-DCRComplexSolve.patch
Comment thread easybuild/easyconfigs/e/Elmer/Elmer-9.0-foss-2022b.eb Outdated
Comment thread easybuild/easyconfigs/e/Elmer/Elmer-9.0-foss-2022b.eb
@casparvl
Copy link
Copy Markdown
Contributor

By the way, I'll be going on holiday for a while. After having responded to my comments, feel free to ping another maintainer in the EasyBuild Slack channel if they can finish the review process :)

@easybuilders easybuilders deleted a comment from boegelbot Dec 26, 2023
@easybuilders easybuilders deleted a comment from boegelbot Dec 26, 2023
@easybuilders easybuilders deleted a comment from boegelbot Dec 26, 2023
@kosl
Copy link
Copy Markdown
Contributor Author

kosl commented Dec 27, 2023

@ocaisa Can you please review this PR instead of @casparvl ?

@ocaisa
Copy link
Copy Markdown
Member

ocaisa commented Jan 25, 2024

@boegelbot please test @ generoso

@ocaisa ocaisa added this to the release after 4.9.0 milestone Jan 25, 2024
@boegelbot
Copy link
Copy Markdown
Collaborator

@ocaisa: Request for testing this PR well received on login1

PR test command 'EB_PR=19448 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_19448 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 12731

Test results coming soon (I hope)...

Details

- notification for comment with ID 1910332786 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

Comment thread easybuild/easyconfigs/e/Elmer/Elmer-9.0-foss-2022b.eb Outdated
@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/eca5f59aca93e0dbbf10cdc25369cb32 for a full test report.

Comment thread easybuild/easyconfigs/e/Elmer/Elmer-9.0-foss-2022b.eb Outdated
@ocaisa ocaisa dismissed casparvl’s stale review January 25, 2024 15:16

Comments addressed

@ocaisa
Copy link
Copy Markdown
Member

ocaisa commented Jan 25, 2024

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

@ocaisa: Request for testing this PR well received on login1

PR test command 'EB_PR=19448 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_19448 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 12734

Test results coming soon (I hope)...

Details

- notification for comment with ID 1911041447 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@ocaisa
Copy link
Copy Markdown
Member

ocaisa commented Jan 25, 2024

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Copy Markdown
Collaborator

@ocaisa: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=19448 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_19448 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 3480

Test results coming soon (I hope)...

Details

- notification for comment with ID 1911042009 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/814a2183c547d31553622052e4a4c939 for a full test report.

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 5 out of 5 (2 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.3, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/0a40367da3ed79a3d9787346d08e031d for a full test report.

@ocaisa
Copy link
Copy Markdown
Member

ocaisa commented Jan 25, 2024

Going in, thanks @kosl !

@ocaisa ocaisa merged commit 4ed58b6 into easybuilders:develop Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants