Skip to content

add missing SciPy-bundle dependency to TensorRT easyconfig#19486

Merged
akesandgren merged 1 commit intoeasybuilders:developfrom
boegel:20240103210834_new_pr_TensorRT861
Jan 4, 2024
Merged

add missing SciPy-bundle dependency to TensorRT easyconfig#19486
akesandgren merged 1 commit intoeasybuilders:developfrom
boegel:20240103210834_new_pr_TensorRT861

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Jan 3, 2024 •
edited
Loading

(created using eb --new-pr)
without this, pip check fails with: uff 0.6.9 requires numpy, which is not installed

@boegel boegel mentioned this pull request Jan 3, 2024
Merged
@boegel boegel added the bug fix label Jan 3, 2024
@boegel boegel added this to the release after 4.9.0 milestone Jan 3, 2024
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Jan 3, 2024

Test report by @boegel
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#3022
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3608.doduo.os - Linux RHEL 8.8, x86_64, AMD EPYC 7552 48-Core Processor (zen2), Python 3.6.8
See https://gist.github.com/boegel/40bc543aa1ce3d4380b9147f42d89912 for a full test report.

@easybuilders easybuilders deleted a comment from boegelbot Jan 3, 2024
@easybuilders easybuilders deleted a comment from boegelbot Jan 3, 2024
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Jan 3, 2024

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jan 3, 2024

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=19486 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_19486 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 12492

Test results coming soon (I hope)...

Details

- notification for comment with ID 1876042083 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jan 3, 2024

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/f6803bb488d94e4630970e175d1c703d for a full test report.

akesandgren
akesandgren approved these changes Jan 4, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@akesandgren akesandgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akesandgren
Copy link
Copy Markdown
Contributor

akesandgren commented Jan 4, 2024

Going in, thanks @boegel!

@akesandgren akesandgren merged commit 6433e81 into easybuilders:develop Jan 4, 2024
@boegel boegel deleted the 20240103210834_new_pr_TensorRT861 branch January 4, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akesandgren akesandgren akesandgren approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.9.1

Development

Successfully merging this pull request may close these issues.

3 participants

@boegel @boegelbot @akesandgren