Skip to content

rename VSCode to VSCode-cli#19585

Merged
boegel merged 3 commits intoeasybuilders:developfrom
laraPPr:20240115095459_new_pr_VSCode-cli1851
Jan 15, 2024
Merged

rename VSCode to VSCode-cli#19585
boegel merged 3 commits intoeasybuilders:developfrom
laraPPr:20240115095459_new_pr_VSCode-cli1851

Conversation

@laraPPr
Copy link
Copy Markdown
Contributor

@laraPPr laraPPr commented Jan 15, 2024 •
edited by boegel
Loading

(created using eb --new-pr)

follow-up for #19418

@boegel boegel changed the title {devel}[system/system] VSCode-cli v1.85.1 w/ x64 rename VSCode to VSCode-cli Jan 15, 2024
@boegel boegel added the change label Jan 15, 2024
@boegel boegel added this to the release after 4.9.0 milestone Jan 15, 2024
@boegel
Copy link
Copy Markdown
Member

boegel commented Jan 15, 2024

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3147.skitty.os - Linux RHEL 8.8, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/boegel/3ceb75ca438111fd012536dbe5d808df for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Jan 15, 2024

@boegelbot please test @ generoso

boegel
boegel approved these changes Jan 15, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VSCode is indeed a confusing name, since this is a pure CLI tool

lgtm

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jan 15, 2024

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=19585 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_19585 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 12611

Test results coming soon (I hope)...

Details

- notification for comment with ID 1891760156 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jan 15, 2024

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns2 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/b237a6487d20d1366a082011ac50ed37 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Jan 15, 2024

Going in, thanks @laraPPr!

@boegel boegel merged commit 2139587 into easybuilders:develop Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

change

Projects

None yet

Milestone

4.9.1

Development

Successfully merging this pull request may close these issues.

3 participants

@laraPPr @boegel @boegelbot