Skip to content

{devel}[system/system] Eclipse-SDK v4.30, Eclipse-java v2023.12 w/ Java 21#19621

Merged
boegel merged 5 commits intoeasybuilders:developfrom
SimonPinches:20240117190536_new_pr_Eclipse-SDK430
Aug 18, 2025
Merged

{devel}[system/system] Eclipse-SDK v4.30, Eclipse-java v2023.12 w/ Java 21#19621
boegel merged 5 commits intoeasybuilders:developfrom
SimonPinches:20240117190536_new_pr_Eclipse-SDK430

Conversation

@SimonPinches
Copy link
Copy Markdown
Contributor

(created using eb --new-pr)

…-Java-21.eb and patches: eclipse-java-2023.12_fix_path.patch
@SimonPinches
Copy link
Copy Markdown
Contributor Author

This PR relies upon #19620.

@boegelbot

This comment was marked as outdated.

Micket
Micket previously requested changes Apr 1, 2024
--launcher.appendVmargs
-vm
-plugins/org.eclipse.justj.openjdk.hotspot.jre.full.linux.x86_64_17.0.9.v20231028-0858/jre/bin/java
+/work/imas/opt/EasyBuild/software/Java/17.0.6/bin/java
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this clearly won't work for anyone else

@@ -0,0 +1,12 @@
diff -Nru eclipse-orig/eclipse.ini eclipse/eclipse.ini
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a description on author to patches

versionsuffix = "-Java-21"

homepage = 'http://www.eclipse.org'
description = """Integrated Development Environment"""
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

description doesn't seem correct here

versionsuffix = "-Java-21"

homepage = 'http://www.eclipse.org'
description = """Integrated Development Environment"""
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems way to short of a description to me
Maybe (taken from website)

The essential tools for any Java developer, including a Java IDE, a Git client, XML Editor, Maven and Gradle integration

@@ -0,0 +1,36 @@
easyblock = 'Tarball'

name = 'Eclipse-java'
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should say something like IDE in there

@Micket Micket added the new label Apr 1, 2024
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Copy Markdown
Member

boegel commented Aug 18, 2025

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
node3513.doduo.os - Linux RHEL 9.4, x86_64, AMD EPYC 7552 48-Core Processor (zen2), Python 3.9.18
See https://gist.github.com/boegel/36b94a08ee72342721fa9244a7a42faa for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Aug 18, 2025

@boegelbot please test @ jsc-zen3

Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegelbot
Copy link
Copy Markdown
Collaborator

@boegel: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=19621 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_19621 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 7662

Test results coming soon (I hope)...

Details

- notification for comment with ID 3197318780 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
jsczen3c2.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.6, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.21
See https://gist.github.com/boegelbot/ec67ea9421b923141472351676c2b343 for a full test report.

@boegel boegel dismissed Micket’s stale review August 18, 2025 15:21

requested changes done

@boegel boegel added this to the next release (5.1.2) milestone Aug 18, 2025
@boegel
Copy link
Copy Markdown
Member

boegel commented Aug 18, 2025

Going in, thanks @SimonPinches!

@boegel boegel merged commit 6f3411f into easybuilders:develop Aug 18, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants