Skip to content

use https source URL for alsa-lib#19628

Merged
SebastianAchilles merged 1 commit intoeasybuilders:developfrom
boegel:20240118121613_new_pr_alsa-lib124
Jan 18, 2024
Merged

use https source URL for alsa-lib#19628
SebastianAchilles merged 1 commit intoeasybuilders:developfrom
boegel:20240118121613_new_pr_alsa-lib124

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Jan 18, 2024

(created using eb --new-pr)
FTP is blocked on some systems, we should use HTTP(S) whenever we can

@boegel boegel added this to the release after 4.9.0 milestone Jan 18, 2024
@boegel boegel added the bug fix label Jan 18, 2024
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Jan 18, 2024

@boegelbot please test @ generoso
EB_ARGS="--force-download --sourcepath /tmp/$USER/sources"

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jan 18, 2024

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=19628 EB_ARGS="--force-download --sourcepath /tmp/$USER/sources" EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_19628 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 12654

Test results coming soon (I hope)...

Details

- notification for comment with ID 1898284820 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jan 18, 2024

Test report by @boegelbot
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/ff1d9bd49883505e21383174896d0eb6 for a full test report.

SebastianAchilles
SebastianAchilles approved these changes Jan 18, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@SebastianAchilles SebastianAchilles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SebastianAchilles
Copy link
Copy Markdown
Member

SebastianAchilles commented Jan 18, 2024

Going in, thanks @boegel!

@SebastianAchilles SebastianAchilles merged commit e0c741f into easybuilders:develop Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SebastianAchilles SebastianAchilles SebastianAchilles approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.9.1

Development

Successfully merging this pull request may close these issues.

3 participants

@boegel @boegelbot @SebastianAchilles