Skip to content

add libyaml import check to PyYAML and fix builds since split to minimal Python#19662

Merged
SebastianAchilles merged 1 commit intoeasybuilders:developfrom
branfosj:20240121144506_new_pr_PyYAML601
Jan 22, 2024
Merged

add libyaml import check to PyYAML and fix builds since split to minimal Python#19662
SebastianAchilles merged 1 commit intoeasybuilders:developfrom
branfosj:20240121144506_new_pr_PyYAML601

Conversation

@branfosj
Copy link
Copy Markdown
Member

@branfosj branfosj commented Jan 21, 2024 •
edited by boegel
Loading

(created using eb --new-pr)

Fixing the error reported in #19661

  • add sanity check to all 6.x PyYAML
  • fix builds since split to minimal Python by adding Python-bundle-PyPI to provide Cython
  • additional fix in 6.0.1 to make PyYAML build with Cython 3

edit: fixes following error when running python -c 'import yaml; yaml.CLoader':

AttributeError: module 'yaml' has no attribute 'CLoader'. Did you mean: 'Loader'?

@branfosj branfosj added this to the release after 4.9.0 milestone Jan 21, 2024
@branfosj branfosj mentioned this pull request Jan 21, 2024
Closed
@branfosj
Copy link
Copy Markdown
Member Author

branfosj commented Jan 21, 2024

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jan 21, 2024

@branfosj: Request for testing this PR well received on login1

PR test command 'EB_PR=19662 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_19662 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 12685

Test results coming soon (I hope)...

Details

- notification for comment with ID 1902660661 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@branfosj
Copy link
Copy Markdown
Member Author

branfosj commented Jan 21, 2024

Test report by @branfosj
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in total)
bear-pg0105u03b - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Platinum 8360Y CPU @ 2.40GHz (icelake), Python 3.6.8
See https://gist.github.com/branfosj/1349b10abea5610dd2e4ffd254563d6e for a full test report.

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jan 21, 2024

Test report by @boegelbot
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/d807e27deb015c41da66c9192f47b053 for a full test report.

@branfosj
Copy link
Copy Markdown
Member Author

branfosj commented Jan 21, 2024

@boegelbot please test @ jsc-zen2

@SebastianAchilles
Copy link
Copy Markdown
Member

SebastianAchilles commented Jan 22, 2024

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jan 22, 2024

@SebastianAchilles: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=19662 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_19662 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 3444

Test results coming soon (I hope)...

Details

- notification for comment with ID 1903569406 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@SebastianAchilles
Copy link
Copy Markdown
Member

SebastianAchilles commented Jan 22, 2024

Test report by @SebastianAchilles
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in total)
bwd-rockylinux-93 - Linux Rocky Linux 9.3 (Blue Onyx), x86_64, Intel(R) Core(TM) i7-6900K CPU @ 3.20GHz (broadwell), Python 3.9.18
See https://gist.github.com/SebastianAchilles/1687e634f972f2ee79981e142bd76a37 for a full test report.

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jan 22, 2024

Test report by @boegelbot
SUCCESS
Build succeeded for 11 out of 11 (4 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.3, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/2864c354d679def50f204f491bc7ac9d for a full test report.

SebastianAchilles
SebastianAchilles approved these changes Jan 22, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@SebastianAchilles SebastianAchilles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SebastianAchilles
Copy link
Copy Markdown
Member

SebastianAchilles commented Jan 22, 2024

Going in, thanks @branfosj!

@SebastianAchilles SebastianAchilles merged commit 8bb7c62 into easybuilders:develop Jan 22, 2024
@branfosj branfosj deleted the 20240121144506_new_pr_PyYAML601 branch January 22, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SebastianAchilles SebastianAchilles SebastianAchilles approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.9.1

Development

Successfully merging this pull request may close these issues.

3 participants

@branfosj @boegelbot @SebastianAchilles