Skip to content

strip iconv from pkgconfig file for libarchive v3.6.2#19698

Merged
branfosj merged 3 commits intoeasybuilders:developfrom
jfgrimm:20240123165517_new_pr_libarchive362
Feb 10, 2024
Merged

strip iconv from pkgconfig file for libarchive v3.6.2#19698
branfosj merged 3 commits intoeasybuilders:developfrom
jfgrimm:20240123165517_new_pr_libarchive362

Conversation

@jfgrimm
Copy link
Copy Markdown
Member

@jfgrimm jfgrimm commented Jan 23, 2024 •
edited
Loading

we're not building libarchive with libiconv as a dependency, and it's not hard required. However, the libarchive.pc file has an iconv entry, causing software picking up libarchive via pkg{conf,-config} to error. Building with libiconv doesn't even fix this, since libiconv installs no libiconv.pc file

(created using eb --new-pr)

@jfgrimm jfgrimm mentioned this pull request Jan 23, 2024
Merged
2 tasks
@jfgrimm jfgrimm added this to the release after 4.9.0 milestone Jan 23, 2024
@boegelbot

This comment was marked as resolved.

Sign in to view
@boegelbot

This comment was marked as resolved.

Sign in to view
@verdurin
Copy link
Copy Markdown
Member

verdurin commented Jan 25, 2024

Test report by @verdurin
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
easybuild-c7.novalocal - Linux CentOS Linux 7.9.2009, x86_64, Intel Xeon Processor (Skylake, IBRS), Python 3.6.8
See https://gist.github.com/verdurin/5f91adb62fc0721aebab5a3c548c6ce1 for a full test report.

@verdurin
Copy link
Copy Markdown
Member

verdurin commented Jan 25, 2024

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jan 25, 2024

@verdurin: Request for testing this PR well received on login1

PR test command 'EB_PR=19698 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_19698 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 12719

Test results coming soon (I hope)...

Details

- notification for comment with ID 1909766511 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jan 25, 2024

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/4482176eb047eb9d09f6c28e3bdd4fc0 for a full test report.

@boegel boegel changed the title strip iconv from libarchive pkgconfig file strip iconv from pkgconfig file for libarchive v3.6.2 Jan 31, 2024
@boegel
Copy link
Copy Markdown
Member

boegel commented Jan 31, 2024

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jan 31, 2024

@boegel: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=19698 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_19698 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 3527

Test results coming soon (I hope)...

Details

- notification for comment with ID 1918658793 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jan 31, 2024

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.3, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/0208fb71b58b8299b26256c182c1f252 for a full test report.

@branfosj
Copy link
Copy Markdown
Member

branfosj commented Feb 10, 2024

Test report by @branfosj
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
bear-pg0105u03a - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Platinum 8360Y CPU @ 2.40GHz (icelake), Python 3.6.8
See https://gist.github.com/branfosj/a41dabb564cfa0ecc5e3c434f0943577 for a full test report.

@branfosj
Copy link
Copy Markdown
Member

branfosj commented Feb 10, 2024

Going in, thanks @jfgrimm!

@branfosj branfosj merged commit 3390124 into easybuilders:develop Feb 10, 2024
@branfosj
Copy link
Copy Markdown
Member

branfosj commented Feb 10, 2024

Also built CMake-3.26.3-GCCcore-12.3.0.eb, mpifileutils-0.11.1-gompi-2023a.eb, elfutils-0.189-GCCcore-12.3.0.eb, GDAL-3.7.1-foss-2023a.eb on top of this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@branfosj branfosj branfosj approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.9.1

Development

Successfully merging this pull request may close these issues.

5 participants

@jfgrimm @boegelbot @verdurin @boegel @branfosj