Skip to content

remove urllib3 extension from wandb easyconfig, not needed since Python-bundle-PyPI dependency already provides it#19725

Merged
jfgrimm merged 1 commit intoeasybuilders:developfrom
akesandgren:20240125160212_new_pr_wandb0161
Jan 25, 2024
Merged

remove urllib3 extension from wandb easyconfig, not needed since Python-bundle-PyPI dependency already provides it#19725
jfgrimm merged 1 commit intoeasybuilders:developfrom
akesandgren:20240125160212_new_pr_wandb0161

Conversation

@akesandgren
Copy link
Copy Markdown
Contributor

@akesandgren akesandgren commented Jan 25, 2024

(created using eb --new-pr)

@akesandgren akesandgren added this to the 4.x milestone Jan 25, 2024
@akesandgren
Copy link
Copy Markdown
Contributor Author

akesandgren commented Jan 25, 2024

Test report by @akesandgren
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
b-an02.hpc2n.umu.se - Linux Ubuntu 20.04, x86_64, Intel(R) Xeon(R) CPU E5-2690 v4 @ 2.60GHz, Python 3.8.10
See https://gist.github.com/akesandgren/8b388742aae282dc8ec7ef1c4b072d79 for a full test report.

jfgrimm
jfgrimm approved these changes Jan 25, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@jfgrimm jfgrimm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented Jan 25, 2024

@boegelbot: please test @ jsc-zen3

@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented Jan 25, 2024

Test report by @jfgrimm
SUCCESS
Build succeeded for 2 out of 2 (1 easyconfigs in total)
node030.viking2.yor.alces.network - Linux Rocky Linux 8.8, x86_64, AMD EPYC 7643 48-Core Processor, Python 3.6.8
See https://gist.github.com/jfgrimm/ca370dcc6261e81f43a870f54a1047a5 for a full test report.

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jan 25, 2024

@jfgrimm: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=19725 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_19725 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 3479

Test results coming soon (I hope)...

Details

- notification for comment with ID 1910476862 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jan 25, 2024

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.3, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/61578e5b5d48ecaa1b38011fc6e9b81b for a full test report.

@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented Jan 25, 2024

@boegelbot: please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jan 25, 2024

@jfgrimm: Request for testing this PR well received on login1

PR test command 'EB_PR=19725 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_19725 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 12733

Test results coming soon (I hope)...

Details

- notification for comment with ID 1910502937 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Jan 25, 2024

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/8b0d4726dbf4d52805c8c4aa7a163204 for a full test report.

@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented Jan 25, 2024

Going in, thanks @akesandgren!

@jfgrimm jfgrimm merged commit 6bd7acc into easybuilders:develop Jan 25, 2024
@jfgrimm jfgrimm modified the milestones: 4.x, release after 4.9.0 Jan 25, 2024
@akesandgren akesandgren deleted the 20240125160212_new_pr_wandb0161 branch January 26, 2024 06:07
@boegel boegel changed the title wandb should not specify urllib3 since it does not need a newer version then the one in Python-bundle-PyPI remove urllib3 extension from wandb easyconfig, not neeed since Python-bundle-PyPI dependency already provides it Apr 4, 2024
@boegel boegel changed the title remove urllib3 extension from wandb easyconfig, not neeed since Python-bundle-PyPI dependency already provides it remove urllib3 extension from wandb easyconfig, not needed since Python-bundle-PyPI dependency already provides it Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jfgrimm jfgrimm jfgrimm approved these changes

Assignees

No one assigned

Labels

change update

Projects

None yet

Milestone

4.9.1

Development

Successfully merging this pull request may close these issues.

3 participants

@akesandgren @jfgrimm @boegelbot