Skip to content

remove numa configure option from hwloc 2+#19833

Merged
Micket merged 2 commits intoeasybuilders:developfrom
Flamefire:20240212140947_new_pr_hwloc241
Feb 27, 2024
Merged

remove numa configure option from hwloc 2+#19833
Micket merged 2 commits intoeasybuilders:developfrom
Flamefire:20240212140947_new_pr_hwloc241

Conversation

@Flamefire
Copy link
Copy Markdown
Contributor

@Flamefire Flamefire commented Feb 12, 2024 •
edited
Loading

(created using eb --new-pr)

Continuation of #19085 for the other 2.x ECs to avoid the configure warning (in preparation to turn it into an error)

@Flamefire Flamefire changed the title remove numa configure option from hwloc 2.2+ remove numa configure option from hwloc 2+ Feb 12, 2024
@Flamefire
Copy link
Copy Markdown
Contributor Author

Flamefire commented Feb 12, 2024

Test report by @Flamefire
SUCCESS
Build succeeded for 5 out of 5 (5 easyconfigs in total)
n1577 - Linux RHEL 8.7 (Ootpa), x86_64, Intel(R) Xeon(R) Platinum 8470 (icelake), Python 3.8.13
See https://gist.github.com/Flamefire/414b32f359f0a7580b70ef43771bd2e8 for a full test report.

@Flamefire
Copy link
Copy Markdown
Contributor Author

Flamefire commented Feb 12, 2024

Test report by @Flamefire
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
n1577 - Linux RHEL 8.7 (Ootpa), x86_64, Intel(R) Xeon(R) Platinum 8470 (icelake), Python 3.8.13
See https://gist.github.com/Flamefire/09fc16cd86e8b02dd6b5adde353135f3 for a full test report.

@Micket Micket added the bug fix label Feb 14, 2024
@Micket Micket added this to the release after 4.9.0 milestone Feb 14, 2024
Micket
Micket approved these changes Feb 14, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Micket
Copy link
Copy Markdown
Contributor

Micket commented Feb 14, 2024

@boegelbot please test @ generoso
EB_ARGS="hwloc-2.4.1-GCCcore-10.3.0.eb"

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Feb 14, 2024

@Micket: Request for testing this PR well received on login1

PR test command 'EB_PR=19833 EB_ARGS="hwloc-2.4.1-GCCcore-10.3.0.eb" EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_19833 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 12881

Test results coming soon (I hope)...

Details

- notification for comment with ID 1943444572 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Feb 14, 2024

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/8f9c0b56d42d7a6d576c6400fd0bdd64 for a full test report.

@Micket
Copy link
Copy Markdown
Contributor

Micket commented Feb 27, 2024

Going in, thanks @Flamefire!

@Micket Micket merged commit 1715683 into easybuilders:develop Feb 27, 2024
@Flamefire Flamefire deleted the 20240212140947_new_pr_hwloc241 branch February 27, 2024 08:05
@boegel boegel mentioned this pull request Mar 11, 2024
Merged
84 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Micket Micket Micket approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.9.1

Development

Successfully merging this pull request may close these issues.

3 participants

@Flamefire @Micket @boegelbot