Skip to content

add hidden=True to run_shell_cmd use in testsuite#19886

Merged
Micket merged 1 commit intoeasybuilders:5.0.xfrom
branfosj:hidden
Feb 18, 2024
Merged

add hidden=True to run_shell_cmd use in testsuite#19886
Micket merged 1 commit intoeasybuilders:5.0.xfrom
branfosj:hidden

Conversation

@branfosj
Copy link
Copy Markdown
Member

@branfosj branfosj commented Feb 17, 2024

Currently we see the information for the command we run repeated several times.

   >> running command:
	[started at: 2024-02-18 08:25:30]
	[working dir: /home/runner/work/easybuild-easyconfigs/easybuild-easyconfigs]
	[output saved to /tmp/eb-ezpo529j/eb-6nea9o24/run-shell-cmd-output/git-wp5r1raf/out.txt]
	git merge-base 5.0.x HEAD
  >> command completed: exit 0, ran in < 1s
Merge base for 5.0.x and HEAD: f92b7bda2b783094292b158b2ac99ff248ac39c1

This change removes this, so the output is much cleaner.

This is also closer to the existing output, see https://github.com/easybuilders/easybuild-easyconfigs/actions/runs/7945029976/job/21691174270?pr=19877 for example.

@branfosj branfosj added tests EasyBuild-5.0 EasyBuild 5.0 labels Feb 17, 2024
@branfosj branfosj added this to the 5.0 milestone Feb 17, 2024
Copy link
Copy Markdown
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Micket Micket merged commit b12afba into easybuilders:5.0.x Feb 18, 2024
@branfosj branfosj deleted the hidden branch February 18, 2024 16:01
@boegel boegel added the bug fix label Feb 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: No status

Development

Successfully merging this pull request may close these issues.

3 participants