Skip to content

stop using non-existing --with-doc configure option for groff 1.23#19969

Merged
jfgrimm merged 1 commit intoeasybuilders:developfrom
Flamefire:20240226102917_new_pr_groff1230
Feb 26, 2024
Merged

stop using non-existing --with-doc configure option for groff 1.23#19969
jfgrimm merged 1 commit intoeasybuilders:developfrom
Flamefire:20240226102917_new_pr_groff1230

Conversation

@Flamefire
Copy link
Copy Markdown
Contributor

@Flamefire Flamefire commented Feb 26, 2024 •
edited
Loading

(created using eb --new-pr)

This was removed from 1.23.0. From the NEWS:

The 'configure' option '--with-doc' that was introduced in version 1.22.3 has been deleted again. Its basic idea was misguided because each of the documents is only available in a subset of the output formats, so in contrast to the documentation, the option not only affected which output formats were generated, but also restricted the documentation content the user would get in erratic and surprising ways. The option was also ill-designed insofar as the "examples" keyword did not represent an output format. Some example files were controlled by the "examples" keyword alone, some by the respective format keywords alone, and some by a combination of both. The implementation of the option was full of bugs, but few, if any, of these bugs were ever reported by users, giving the impression that few, if any, users ever attempted to use the option, and those who did likely remained unaware that doing so deprived them of parts of the content of the documentation. Experience has demonstrated that properly maintaining and testing the option exceeds the amount of effort the GNU troff team is able to invest. Finally, GNU standards contain no recommendation to support this option, and indeed, few, if any, GNU packages apart from groff support it.

@Flamefire
Copy link
Copy Markdown
Contributor Author

Flamefire commented Feb 26, 2024

Test report by @Flamefire
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
i8021 - Linux Rocky Linux 8.7, x86_64, AMD EPYC 7352 24-Core Processor (zen2), 8 x NVIDIA NVIDIA A100-SXM4-40GB, 545.23.08, Python 3.6.8
See https://gist.github.com/Flamefire/4243263d8386591546b36bedf8b1608b for a full test report.

@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented Feb 26, 2024

@boegelbot: please test @ generoso

@jfgrimm jfgrimm added this to the release after 4.9.0 milestone Feb 26, 2024
@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Feb 26, 2024

@jfgrimm: Request for testing this PR well received on login1

PR test command 'EB_PR=19969 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_19969 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 12962

Test results coming soon (I hope)...

Details

- notification for comment with ID 1963883508 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Feb 26, 2024

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/2a61ce5877e9d6b1effb29e0cfab5823 for a full test report.

@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented Feb 26, 2024

@boegelbot: please test @ jsc-zen3

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Feb 26, 2024

@jfgrimm: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=19969 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_19969 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 3673

Test results coming soon (I hope)...

Details

- notification for comment with ID 1963923680 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Feb 26, 2024

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.3, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/c2c27675d78770597d3bb2414d228a26 for a full test report.

@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented Feb 26, 2024

Test report by @jfgrimm
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node031.viking2.yor.alces.network - Linux Rocky Linux 8.8, x86_64, AMD EPYC 7643 48-Core Processor, Python 3.6.8
See https://gist.github.com/jfgrimm/b03774994f5aacf4585954e397eb9783 for a full test report.

@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented Feb 26, 2024

Going in, thanks @Flamefire!

@jfgrimm jfgrimm merged commit 02ca411 into easybuilders:develop Feb 26, 2024
@Flamefire Flamefire deleted the 20240226102917_new_pr_groff1230 branch February 26, 2024 13:10
@boegel boegel changed the title Remove --with-doc configure option from groff 1.23 stop using non-existing --with-doc configure option for groff 1.23 Feb 28, 2024
@boegel boegel mentioned this pull request Mar 11, 2024
Merged
84 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jfgrimm jfgrimm jfgrimm approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.9.1

Development

Successfully merging this pull request may close these issues.

3 participants

@Flamefire @jfgrimm @boegelbot