Skip to content

Remove --disable-docs configure option from FriBidi 1.0.5+#19998

Merged
ocaisa merged 1 commit intoeasybuilders:developfrom
Flamefire:20240229094502_new_pr_FriBidi1010
Feb 29, 2024
Merged

Remove --disable-docs configure option from FriBidi 1.0.5+#19998
ocaisa merged 1 commit intoeasybuilders:developfrom
Flamefire:20240229094502_new_pr_FriBidi1010

Conversation

@Flamefire
Copy link
Copy Markdown
Contributor

@Flamefire Flamefire commented Feb 29, 2024 •
edited
Loading

(created using eb --new-pr)

The option was introduced to 1.0.2 but removed in 1.0.3: fribidi/fribidi#73

@Flamefire
Copy link
Copy Markdown
Contributor Author

Flamefire commented Feb 29, 2024

Test report by @Flamefire
SUCCESS
Build succeeded for 11 out of 11 (6 easyconfigs in total)
n1358 - Linux RHEL 8.7 (Ootpa), x86_64, Intel(R) Xeon(R) Platinum 8470 (icelake), Python 3.8.13
See https://gist.github.com/Flamefire/230707720733148580a4882900506631 for a full test report.

@ocaisa
Copy link
Copy Markdown
Member

ocaisa commented Feb 29, 2024

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Feb 29, 2024

@ocaisa: Request for testing this PR well received on login1

PR test command 'EB_PR=19998 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_19998 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 12993

Test results coming soon (I hope)...

Details

- notification for comment with ID 1971299007 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Feb 29, 2024

Test report by @boegelbot
SUCCESS
Build succeeded for 7 out of 7 (7 easyconfigs in total)
cns1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/553ef0a27f7d400ebb07be324684422e for a full test report.

@ocaisa ocaisa added this to the release after 4.9.0 milestone Feb 29, 2024
@ocaisa
Copy link
Copy Markdown
Member

ocaisa commented Feb 29, 2024

@boegelbot please test @ generoso
EB_ARGS="--include-easyblocks-from-pr 3026"

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Feb 29, 2024

@ocaisa: Request for testing this PR well received on login1

PR test command 'EB_PR=19998 EB_ARGS="--include-easyblocks-from-pr 3026" EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_19998 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 12994

Test results coming soon (I hope)...

Details

- notification for comment with ID 1971324785 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Feb 29, 2024

Test report by @boegelbot
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#3026
SUCCESS
Build succeeded for 7 out of 7 (7 easyconfigs in total)
cns1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/4123a5c0ee189b1865065398b1a30729 for a full test report.

@ocaisa
Copy link
Copy Markdown
Member

ocaisa commented Feb 29, 2024

Going in, thanks @Flamefire

@ocaisa ocaisa merged commit 98fe2fe into easybuilders:develop Feb 29, 2024
@Flamefire Flamefire deleted the 20240229094502_new_pr_FriBidi1010 branch March 1, 2024 09:49
@boegel boegel added the bug fix label Mar 11, 2024
@boegel boegel mentioned this pull request Mar 11, 2024
Merged
84 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ocaisa ocaisa ocaisa approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.9.1

Development

Successfully merging this pull request may close these issues.

4 participants

@Flamefire @ocaisa @boegelbot @boegel