Skip to content

Remove hdf5 configure option from MDSplus 7.96.12#20041

Merged
jfgrimm merged 1 commit intoeasybuilders:developfrom
Flamefire:20240305151816_new_pr_MDSplus79612
Mar 5, 2024
Merged

Remove hdf5 configure option from MDSplus 7.96.12#20041
jfgrimm merged 1 commit intoeasybuilders:developfrom
Flamefire:20240305151816_new_pr_MDSplus79612

Conversation

@Flamefire
Copy link
Copy Markdown
Contributor

@Flamefire Flamefire commented Mar 5, 2024 •
edited
Loading

(created using eb --new-pr)

Added in #10705 but that doesn't seem to have been a valid configure option ever. In the configure script I only see a check for $HDF5_DIR or so.

@Flamefire
Copy link
Copy Markdown
Contributor Author

Flamefire commented Mar 5, 2024

Test report by @Flamefire
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
n1358 - Linux RHEL 8.7 (Ootpa), x86_64, Intel(R) Xeon(R) Platinum 8470 (icelake), Python 3.8.13
See https://gist.github.com/Flamefire/2814c8db518678d2ab8c6aa194973988 for a full test report.

@jfgrimm jfgrimm added the bug fix label Mar 5, 2024
@jfgrimm jfgrimm added this to the release after 4.9.0 milestone Mar 5, 2024
@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented Mar 5, 2024

Test report by @jfgrimm
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node074.viking2.yor.alces.network - Linux Rocky Linux 8.8, x86_64, AMD EPYC 7643 48-Core Processor, Python 3.6.8
See https://gist.github.com/jfgrimm/83c50de67af050afb2b3103fcf7c2ab4 for a full test report.

@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented Mar 5, 2024

@boegelbot: please test @ generoso

jfgrimm
jfgrimm approved these changes Mar 5, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@jfgrimm jfgrimm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Mar 5, 2024

@jfgrimm: Request for testing this PR well received on login1

PR test command 'EB_PR=20041 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_20041 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 13032

Test results coming soon (I hope)...

Details

- notification for comment with ID 1979146857 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Mar 5, 2024

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/0b87e35daed5c2e0c93b15aca80d6f17 for a full test report.

@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented Mar 5, 2024

Going in, thanks @Flamefire!

@jfgrimm jfgrimm merged commit c048d29 into easybuilders:develop Mar 5, 2024
@Flamefire Flamefire deleted the 20240305151816_new_pr_MDSplus79612 branch March 5, 2024 18:42
@boegel boegel mentioned this pull request Mar 11, 2024
Merged
84 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jfgrimm jfgrimm jfgrimm approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.9.1

Development

Successfully merging this pull request may close these issues.

3 participants

@Flamefire @jfgrimm @boegelbot