Skip to content

fix configure option and remove gperftools dependency for MIRA 5.0#20061

Merged
Micket merged 1 commit intoeasybuilders:developfrom
Flamefire:20240307090543_new_pr_MIRA50rc2
Mar 11, 2024
Merged

fix configure option and remove gperftools dependency for MIRA 5.0#20061
Micket merged 1 commit intoeasybuilders:developfrom
Flamefire:20240307090543_new_pr_MIRA50rc2

Conversation

@Flamefire
Copy link
Copy Markdown
Contributor

@Flamefire Flamefire commented Mar 7, 2024 •
edited
Loading

(created using eb --new-pr)

with-tcmalloc-dir doesn't exist and 4.9.4 changelog shows:

MIRA does not link per default to TCMalloc library anymore.

Even after build with the gperftools dependency I couldn't find any reference to it in the install tree or configure log

@Flamefire
Copy link
Copy Markdown
Contributor Author

Flamefire commented Mar 7, 2024

Test report by @Flamefire
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
n1358 - Linux RHEL 8.7 (Ootpa), x86_64, Intel(R) Xeon(R) Platinum 8470 (icelake), Python 3.8.13
See https://gist.github.com/Flamefire/974da5bc15b8492eac5b2eed2cb560df for a full test report.

Micket
Micket reviewed Mar 7, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Micket
Micket approved these changes Mar 7, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Micket
Copy link
Copy Markdown
Contributor

Micket commented Mar 7, 2024

@boegelbot please test @ generoso

@Micket Micket added the bug fix label Mar 7, 2024
@Micket Micket added this to the release after 4.9.0 milestone Mar 7, 2024
@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Mar 7, 2024

@Micket: Request for testing this PR well received on login1

PR test command 'EB_PR=20061 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_20061 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 13050

Test results coming soon (I hope)...

Details

- notification for comment with ID 1984764779 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Mar 7, 2024

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/42f97df86fb7321da5c6382a47cfffcc for a full test report.

@Micket
Copy link
Copy Markdown
Contributor

Micket commented Mar 11, 2024

Going in, thanks @Flamefire!

@Micket Micket merged commit 247b3a8 into easybuilders:develop Mar 11, 2024
@Flamefire Flamefire deleted the 20240307090543_new_pr_MIRA50rc2 branch March 11, 2024 12:12
@boegel boegel mentioned this pull request Mar 11, 2024
Merged
84 tasks
@boegel boegel changed the title Fix configure option and gpertools dependency of MIRA 5.0 Fix configure option and gperftools dependency of MIRA 5.0 Apr 4, 2024
@boegel boegel changed the title Fix configure option and gperftools dependency of MIRA 5.0 fix configure option and remove gperftools dependency for MIRA 5.0 Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Micket Micket Micket approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.9.1

Development

Successfully merging this pull request may close these issues.

3 participants

@Flamefire @Micket @boegelbot