Skip to content

Fix configure options in GRASS#20062

Merged
Micket merged 1 commit intoeasybuilders:developfrom
Flamefire:20240307102053_new_pr_GRASS783
Mar 11, 2024
Merged

Fix configure options in GRASS#20062
Micket merged 1 commit intoeasybuilders:developfrom
Flamefire:20240307102053_new_pr_GRASS783

Conversation

@Flamefire
Copy link
Copy Markdown
Contributor

@Flamefire Flamefire commented Mar 7, 2024

(created using eb --new-pr)

@Flamefire
Copy link
Copy Markdown
Contributor Author

Flamefire commented Mar 7, 2024

Test report by @Flamefire
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
n1493 - Linux RHEL 8.7 (Ootpa), x86_64, Intel(R) Xeon(R) Platinum 8470 (icelake), Python 3.8.13
See https://gist.github.com/Flamefire/03d1b21462d4426092e8e1f2ad763c78 for a full test report.

@Micket Micket added the bug fix label Mar 7, 2024
@boegel boegel mentioned this pull request Mar 11, 2024
Merged
84 tasks
Micket
Micket approved these changes Mar 11, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Micket Micket added this to the release after 4.9.0 milestone Mar 11, 2024
@Micket
Copy link
Copy Markdown
Contributor

Micket commented Mar 11, 2024

@boegelbot please test @ generoso
EB_ARGS="GRASS-8.2.0-foss-2021b.eb"

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Mar 11, 2024

@Micket: Request for testing this PR well received on login1

PR test command 'EB_PR=20062 EB_ARGS="GRASS-8.2.0-foss-2021b.eb" EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_20062 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 13069

Test results coming soon (I hope)...

Details

- notification for comment with ID 1988667812 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Mar 11, 2024

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns2 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/0c7cd3a9f3f8ecd4255e5a503065c403 for a full test report.

@Micket
Copy link
Copy Markdown
Contributor

Micket commented Mar 11, 2024

Going in, thanks @Flamefire!

@Micket Micket merged commit 8eb318b into easybuilders:develop Mar 11, 2024
@Flamefire Flamefire deleted the 20240307102053_new_pr_GRASS783 branch March 11, 2024 15:36
@Micket Micket changed the title Fix confgure options in GRASS Fix configure options in GRASS Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Micket Micket Micket approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.9.1

Development

Successfully merging this pull request may close these issues.

3 participants

@Flamefire @Micket @boegelbot