Skip to content

fix finding correct Python for MDI#20083

Merged
verdurin merged 2 commits intoeasybuilders:developfrom
branfosj:20240311154906_new_pr_MDI1416
Mar 13, 2024
Merged

fix finding correct Python for MDI#20083
verdurin merged 2 commits intoeasybuilders:developfrom
branfosj:20240311154906_new_pr_MDI1416

Conversation

@branfosj
Copy link
Copy Markdown
Member

(created using eb --new-pr)

Micket
Micket previously approved these changes Mar 11, 2024
Copy link
Copy Markdown
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Micket Micket added the bug fix label Mar 11, 2024
@Micket Micket added this to the release after 4.9.0 milestone Mar 11, 2024
@Micket
Copy link
Copy Markdown
Contributor

Micket commented Mar 11, 2024

Test report by @Micket
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
vera-gpu1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) Gold 6130 CPU @ 2.10GHz, 1 x NVIDIA Tesla V100-SXM2-32GB, 545.23.08, Python 3.6.8
See https://gist.github.com/Micket/ba7705f0f72840c4ad9cdda870d2cdc6 for a full test report.

@branfosj branfosj marked this pull request as draft March 11, 2024 16:25
@branfosj
Copy link
Copy Markdown
Member Author

Test report by @branfosj
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
bear-pg0105u03a - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Platinum 8360Y CPU @ 2.40GHz (icelake), Python 3.6.8
See https://gist.github.com/branfosj/2aea65e4d95c34ebc336fd335cf55af4 for a full test report.

@branfosj branfosj marked this pull request as ready for review March 11, 2024 17:00
Copy link
Copy Markdown
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Micket
Copy link
Copy Markdown
Contributor

Micket commented Mar 11, 2024

Test report by @Micket
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
vera-gpu1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) Gold 6130 CPU @ 2.10GHz, 1 x NVIDIA Tesla V100-SXM2-32GB, 545.23.08, Python 3.6.8
See https://gist.github.com/Micket/31667f71e3d1ab69de058e019b774fcc for a full test report.

@Micket
Copy link
Copy Markdown
Contributor

Micket commented Mar 12, 2024

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

@Micket: Request for testing this PR well received on login1

PR test command 'EB_PR=20083 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_20083 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 13076

Test results coming soon (I hope)...

Details

- notification for comment with ID 1992122116 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
cns3 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/0f585e8ac220d17a68720f1f241480ed for a full test report.

@verdurin
Copy link
Copy Markdown
Member

Test report by @verdurin
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
easybuild-c7.novalocal - Linux CentOS Linux 7.9.2009, x86_64, Intel Xeon Processor (Skylake, IBRS), Python 3.6.8
See https://gist.github.com/verdurin/d3cd1fc271af3f77078bd6e6a3c733e6 for a full test report.

@verdurin
Copy link
Copy Markdown
Member

Going in, thanks @branfosj!

@verdurin verdurin merged commit 1540823 into easybuilders:develop Mar 13, 2024
@branfosj branfosj deleted the 20240311154906_new_pr_MDI1416 branch March 13, 2024 09:42
@boegel
Copy link
Copy Markdown
Member

boegel commented Mar 13, 2024

@branfosj Does this mean that easybuilders/easybuild-easyblocks#3088 isn't working as intended?

@branfosj
Copy link
Copy Markdown
Member Author

branfosj commented Mar 14, 2024

@branfosj Does this mean that easybuilders/easybuild-easyblocks#3088 isn't working as intended?

It is not picking the newest for me and it is not picking the first in the path. Based on the below tests, easybuilders/easybuild-easyblocks#3088 has broken this for me.

Correct Python:

-- Found Python: /rds/projects/2017/branfosj-rse/easybuild/EL8-ice/software/Python/3.11.3-GCCcore-12.3.0/bin/python3.11 (found version "3.11.3") found components: Interpreter Development Development.Module Development.Embed

Incorrect Python:

-- Found Python: /rds/projects/2017/branfosj-rse/easybuild/venv-dev-EL8/bin/python3 (found version "3.6.8") found components: Interpreter Development Development.Module Development.Embed

$PATH just before calling cmake has /rds/projects/2017/branfosj-rse/easybuild/EL8-ice/software/Python/3.11.3-GCCcore-12.3.0/bin before /rds/projects/2017/branfosj-rse/easybuild/venv-dev-EL8/bin.

@boegel
Copy link
Copy Markdown
Member

boegel commented Mar 14, 2024

@branfosj Can you open an issue on this? Keeping track of things in a merged PR is something we should avoid...

@boegel boegel changed the title find correct Python for MDI fix finding correct Python for MDI Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants