{data}[gfbf/2023a] HF-Datasets v2.18.0 by VRehnberg · Pull Request #20166 · easybuilders/easybuild-easyconfigs

VRehnberg · 2024-03-20T13:51:14Z

(created using eb --new-pr)

…ts-2.18.0_use-patched-pyarrow.patch

VRehnberg · 2024-03-20T13:51:55Z

Based on #19795

VRehnberg · 2024-03-20T13:52:11Z

Test report by @VRehnberg
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
alvis-skylake-build - Linux Rocky Linux 8.9, x86_64, Intel Xeon Processor (Skylake, IBRS, no TSX), Python 3.6.8
See https://gist.github.com/VRehnberg/3f8a040bf15ef3b028ed42291c4322ab for a full test report.

casparvl · 2024-03-20T15:54:51Z

@boegelbot please test @ generoso

boegelbot · 2024-03-20T16:00:06Z

@casparvl: Request for testing this PR well received on login1

PR test command 'EB_PR=20166 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_20166 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

exit code: 0
output:

Submitted batch job 13160

Test results coming soon (I hope)...

Details

- notification for comment with ID 2009914375 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

casparvl · 2024-03-20T16:01:08Z

@boegelbot please test @ jsc-zen3

boegelbot · 2024-03-20T16:02:33Z

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns4 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/3eedff7e56fbacfa159bb1aeb4bc4e32 for a full test report.

VRehnberg · 2024-03-20T16:06:04Z

Considering adding a patch to enable using SoftFileLock instead of FileLock. Is a problematic package on some file systems otherwise. huggingface/datasets#6744

casparvl · 2024-03-20T16:10:08Z

Ok, I'll hold off on further testing. Maybe put your PR in Draft mode for now, you can put it back on waiting for review once you've decided / implemented that change.

VRehnberg · 2024-03-20T16:54:33Z

Test report by @VRehnberg
FAILED
Build succeeded for 0 out of 1 (1 easyconfigs in total)
alvis-skylake-build - Linux Rocky Linux 8.9, x86_64, Intel Xeon Processor (Skylake, IBRS, no TSX), Python 3.6.8
See https://gist.github.com/VRehnberg/ce76b268bdfc6d946c54fb304481aae7 for a full test report.

As part of renaming process

VRehnberg · 2024-03-20T17:04:47Z

Test report by @VRehnberg
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
alvis-skylake-build - Linux Rocky Linux 8.9, x86_64, Intel Xeon Processor (Skylake, IBRS, no TSX), Python 3.6.8
See https://gist.github.com/VRehnberg/13d9a03a453d4c01835094dd916ee01a for a full test report.

VRehnberg · 2024-03-20T17:05:18Z

@casparvl I think I'm satisfied now.

VRehnberg · 2024-03-20T17:12:37Z

Test report by @VRehnberg
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
alvis-skylake-build - Linux Rocky Linux 8.9, x86_64, Intel Xeon Processor (Skylake, IBRS, no TSX), Python 3.6.8
See https://gist.github.com/VRehnberg/2e26f21ace58b75ff311f5feea01ad5e for a full test report.

casparvl · 2024-03-21T09:03:46Z

@boegelbot please test @ generoso

boegelbot · 2024-03-21T09:05:08Z

@casparvl: Request for testing this PR well received on login1

PR test command 'EB_PR=20166 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_20166 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

exit code: 0
output:

Submitted batch job 13164

Test results coming soon (I hope)...

Details

- notification for comment with ID 2011684776 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

casparvl · 2024-03-21T09:05:29Z

Test report by @casparvl
FAILED
Build succeeded for 1 out of 2 (1 easyconfigs in total)
tcn1.local.snellius.surf.nl - Linux RHEL 8.6, x86_64, AMD EPYC 7H12 64-Core Processor, Python 3.6.8
See https://gist.github.com/casparvl/826725dfc2838379fb3bdd2e20e888fa for a full test report.

boegelbot · 2024-03-21T09:07:25Z

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/863a3424616c3d39c52a9db9249c535a for a full test report.

casparvl · 2024-03-21T09:07:29Z

crap, I still have this version issue on my system...

datasets 2.18.0 has requirement pyarrow>=14.0.1, but you have pyarrow 0.0.0.

The following Python packages were likely not installed correctly because they show a version of '0.0.0':

I don't get it. It should have been resolved by rebuilding #19777 , which I did... strange :\ Well, as long as it passes on the other systems, I'm going to assume it is my own problem, there is probably something else I should have rebuilt...

casparvl · 2024-03-21T09:08:52Z

@boegelbot please test @ jsc-zen3

boegelbot · 2024-03-21T09:10:07Z

@casparvl: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=20166 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_20166 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

exit code: 0
output:

Submitted batch job 3821

Test results coming soon (I hope)...

Details

- notification for comment with ID 2011695049 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

boegelbot · 2024-03-21T09:12:08Z

Test report by @boegelbot
SUCCESS
Build succeeded for 3 out of 3 (1 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.3, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/00299ea42da435e2c443c46aec828cad for a full test report.

casparvl · 2024-03-21T09:33:33Z

For my own system, I think maybe I need to rebuild #19758 too. I'll try. If that works, it's nice confirmation that this PR can be merged. If I keep hitting the same issue, I'll just ignore the failure on my system - it is clearly not related to this PR.

casparvl · 2024-03-21T10:45:49Z

Test report by @casparvl
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
tcn1.local.snellius.surf.nl - Linux RHEL 8.6, x86_64, AMD EPYC 7H12 64-Core Processor, Python 3.6.8
See https://gist.github.com/casparvl/4561a90331302f193367cfe9807ca315 for a full test report.

casparvl · 2024-03-21T10:50:05Z

Ok, so, indeed:

datasets 2.18.0 has requirement pyarrow>=14.0.1, but you have pyarrow 0.0.0.

The following Python packages were likely not installed correctly because they show a version of '0.0.0':

was resolved for my by rebuilding #19758 . With that, this PR now also succeeds on my system.

casparvl · 2024-03-21T10:55:41Z

Going in, thanks @VRehnberg!

…-foss-2022a.eb Name change (as in PR easybuilders#20166)

adding easyconfigs: Datasets-2.18.0-gfbf-2023a.eb and patches: Datase…

9811155

…ts-2.18.0_use-patched-pyarrow.patch

casparvl added the new label Mar 20, 2024

Micket reviewed Mar 20, 2024

View reviewed changes

Comment thread easybuild/easyconfigs/d/Datasets/Datasets-2.18.0-gfbf-2023a.eb Outdated

VRehnberg and others added 2 commits March 20, 2024 16:50

Add patch to make it possible to use SoftFileLock

4fa3304

Change name to HF-Datasets

dbb3da8

VRehnberg changed the title ~~{data}[gfbf/2023a] Datasets v2.18.0~~ {data}[gfbf/2023a] HF-Datasets v2.18.0 Mar 20, 2024

VRehnberg and others added 2 commits March 20, 2024 17:02

Change extension name to datasets

96df13a

Remove file name Datasets-...

499639d

As part of renaming process

Add comment to patch

e161684

casparvl mentioned this pull request Mar 21, 2024

{data,lib}[GCCcore/11.3.0,foss/2022a] HF-Datasets v2.16.1, pyarrow-hotfix v0.6 #19795

Closed

casparvl added this to the release after 4.9.0 milestone Mar 21, 2024

casparvl approved these changes Mar 21, 2024

View reviewed changes

casparvl merged commit ab0665b into easybuilders:develop Mar 21, 2024

VRehnberg mentioned this pull request Apr 5, 2024

{data,lib}[foss/2022a] HF-Datasets v2.16.1, pyarrow-hotfix v0.6 #20302

Closed

WilleBell added a commit to WilleBell/easybuild-easyconfigs that referenced this pull request Apr 9, 2024

Update and rename Datasets-2.16.1-foss-2022a.eb to HF-Datasets-2.16.1…

3a29c9d

…-foss-2022a.eb Name change (as in PR easybuilders#20166)

Conversation

VRehnberg commented Mar 20, 2024

Uh oh!

VRehnberg commented Mar 20, 2024

Uh oh!

VRehnberg commented Mar 20, 2024

Uh oh!

casparvl commented Mar 20, 2024

Uh oh!

boegelbot commented Mar 20, 2024

Uh oh!

casparvl commented Mar 20, 2024

Uh oh!

boegelbot commented Mar 20, 2024

Uh oh!

VRehnberg commented Mar 20, 2024

Uh oh!

casparvl commented Mar 20, 2024

Uh oh!

Uh oh!

VRehnberg commented Mar 20, 2024

Uh oh!

VRehnberg commented Mar 20, 2024

Uh oh!

VRehnberg commented Mar 20, 2024

Uh oh!

VRehnberg commented Mar 20, 2024

Uh oh!

casparvl commented Mar 21, 2024

Uh oh!

boegelbot commented Mar 21, 2024

Uh oh!

casparvl commented Mar 21, 2024

Uh oh!

boegelbot commented Mar 21, 2024

Uh oh!

casparvl commented Mar 21, 2024

Uh oh!

casparvl commented Mar 21, 2024

Uh oh!

boegelbot commented Mar 21, 2024

Uh oh!

boegelbot commented Mar 21, 2024

Uh oh!

casparvl commented Mar 21, 2024

Uh oh!

casparvl commented Mar 21, 2024

Uh oh!

casparvl commented Mar 21, 2024

Uh oh!

casparvl commented Mar 21, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants