Fix duplicate dict entries and enable fatal error checking for easyconfigs via flake8#20173
Merged
casparvl merged 2 commits intoeasybuilders:developfrom Mar 21, 2024
Merged
Conversation
Contributor
Author
|
@casparvl This is in similar spirit to #20161 and actually fixes some issues Especially the additionally enabled flake8 checks are important to get in fast before new issues pop up (see my PRs for fixing the space issues for good and the executable EC fix which are open for ages now and have to repeatably updated due to conflicts and new issues fixed due to missing CI check) |
casparvl
approved these changes
Mar 21, 2024
Contributor
casparvl
left a comment
There was a problem hiding this comment.
Lgtm. All changes are for EasyConfigs for which the toolchains are deprecated. That makes it difficult, but also less crucial to test. I'll force a merge on this one.
flake8
flake8flake8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enables fatal error checking for ECs via
flake8which includes unknown/undefined variables used and other serious issues.Those found in current ECs are fixed here. Mostly duplicate dict keys which are obviously a mistake.
I kept the last entry each which is what python would use