Skip to content

Enable download_dep_fail in Pythonpackage easyconfigs where it was wrongly disabled#20174

Merged
casparvl merged 1 commit intoeasybuilders:developfrom
Flamefire:20240321090855_new_pr_pytest-cpp230
Mar 21, 2024
Merged

Enable download_dep_fail in Pythonpackage easyconfigs where it was wrongly disabled#20174
casparvl merged 1 commit intoeasybuilders:developfrom
Flamefire:20240321090855_new_pr_pytest-cpp230

Conversation

@Flamefire
Copy link
Copy Markdown
Contributor

@Flamefire Flamefire commented Mar 21, 2024 •
edited
Loading

(created using eb --new-pr)

I was updating some EC and have seen it had download_dep_fail = False for unknown reasons. Especially as we want this as the new default (for 5.x) I searched for other ECs that have this and rebuild them with True. Works for me hence this PR.

Note: SCGid requires a manual download:

(1): Download the installer for ESOM version 1.1 from
https://sourceforge.net/projects/databionic-esom/files/databionic-esom/1.1/esom-1.1-installer.jar
(2): Run the installer, and follow through the installation process using the GUI:
java -jar esom-1.1-installer.jar
(3): Go to the installation directory where you installed ESOM 1.1, and create a tarball:
tar cvzf esom-1.1.tar.gz *
(4): Move esom-1.1.tar.gz to the directory with the SCGid source files (in the EasyBuild sourcepath).

Worked for me as described.

@Flamefire
Copy link
Copy Markdown
Contributor Author

Flamefire commented Mar 21, 2024

Test report by @Flamefire
SUCCESS
Build succeeded for 11 out of 11 (11 easyconfigs in total)
n1227 - Linux RHEL 8.7 (Ootpa), x86_64, Intel(R) Xeon(R) Platinum 8470 (icelake), Python 3.8.13
See https://gist.github.com/Flamefire/e37c1b2904e07245576e14ca2f9a35b6 for a full test report.

@casparvl
Copy link
Copy Markdown
Contributor

casparvl commented Mar 21, 2024

@boegelbot please test @ generoso
EB_ARGS="pytest-cpp-2.3.0-GCCcore-11.3.0.eb pytest-flakefinder-1.1.0-GCCcore-11.3.0.eb pytest-flakefinder-1.1.0-GCCcore-12.2.0.eb pytest-flakefinder-1.1.0-GCCcore-12.3.0.eb pytest-rerunfailures-11.1-GCCcore-11.3.0.eb pytest-rerunfailures-12.0-GCCcore-12.2.0.eb pytest-rerunfailures-12.0-GCCcore-12.3.0.eb pytest-shard-0.1.2-GCCcore-11.3.0.eb pytest-shard-0.1.2-GCCcore-12.2.0.eb pytest-shard-0.1.2-GCCcore-12.3.0.eb"

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Mar 21, 2024

@casparvl: Request for testing this PR well received on login1

PR test command 'EB_PR=20174 EB_ARGS="pytest-cpp-2.3.0-GCCcore-11.3.0.eb pytest-flakefinder-1.1.0-GCCcore-11.3.0.eb pytest-flakefinder-1.1.0-GCCcore-12.2.0.eb pytest-flakefinder-1.1.0-GCCcore-12.3.0.eb pytest-rerunfailures-11.1-GCCcore-11.3.0.eb pytest-rerunfailures-12.0-GCCcore-12.2.0.eb pytest-rerunfailures-12.0-GCCcore-12.3.0.eb pytest-shard-0.1.2-GCCcore-11.3.0.eb pytest-shard-0.1.2-GCCcore-12.2.0.eb pytest-shard-0.1.2-GCCcore-12.3.0.eb" EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_20174 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 13166

Test results coming soon (I hope)...

Details

- notification for comment with ID 2011779427 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@casparvl
Copy link
Copy Markdown
Contributor

casparvl commented Mar 21, 2024

@boegelbot please test @ jsc-zen3
EB_ARGS="pytest-cpp-2.3.0-GCCcore-11.3.0.eb pytest-flakefinder-1.1.0-GCCcore-11.3.0.eb pytest-flakefinder-1.1.0-GCCcore-12.2.0.eb pytest-flakefinder-1.1.0-GCCcore-12.3.0.eb pytest-rerunfailures-11.1-GCCcore-11.3.0.eb pytest-rerunfailures-12.0-GCCcore-12.2.0.eb pytest-rerunfailures-12.0-GCCcore-12.3.0.eb pytest-shard-0.1.2-GCCcore-11.3.0.eb pytest-shard-0.1.2-GCCcore-12.2.0.eb pytest-shard-0.1.2-GCCcore-12.3.0.eb"

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Mar 21, 2024

@casparvl: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=20174 EB_ARGS="pytest-cpp-2.3.0-GCCcore-11.3.0.eb pytest-flakefinder-1.1.0-GCCcore-11.3.0.eb pytest-flakefinder-1.1.0-GCCcore-12.2.0.eb pytest-flakefinder-1.1.0-GCCcore-12.3.0.eb pytest-rerunfailures-11.1-GCCcore-11.3.0.eb pytest-rerunfailures-12.0-GCCcore-12.2.0.eb pytest-rerunfailures-12.0-GCCcore-12.3.0.eb pytest-shard-0.1.2-GCCcore-11.3.0.eb pytest-shard-0.1.2-GCCcore-12.2.0.eb pytest-shard-0.1.2-GCCcore-12.3.0.eb" EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_20174 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 3824

Test results coming soon (I hope)...

Details

- notification for comment with ID 2011790121 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Mar 21, 2024

Test report by @boegelbot
SUCCESS
Build succeeded for 10 out of 10 (10 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.3, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/28a090e0a7e0e8dfaea08f8904fa30fd for a full test report.

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Mar 21, 2024

Test report by @boegelbot
SUCCESS
Build succeeded for 10 out of 10 (10 easyconfigs in total)
cns2 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/9a0610f6cef1de2e7d08080dc4d9d7ba for a full test report.

casparvl
casparvl approved these changes Mar 21, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@casparvl casparvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I kicked off a local build, but I have very little of the 11.2.0 toolchain installed, so that'll take forever. And If I hit issues, it's likely to be one of the dependencies anyway... I'll cancel that, we have two successful builds, that's enough.

Lgtm!

@casparvl casparvl added this to the release after 4.9.0 milestone Mar 21, 2024
@casparvl
Copy link
Copy Markdown
Contributor

casparvl commented Mar 21, 2024

Going in, thanks @Flamefire!

@casparvl casparvl merged commit 7d7666d into easybuilders:develop Mar 21, 2024
@Flamefire Flamefire deleted the 20240321090855_new_pr_pytest-cpp230 branch March 21, 2024 11:12
@boegel boegel changed the title Enable download_dep_fail for Pythonpackage ECs where it was wrongly disabled Enable download_dep_fail for Pythonpackage ECs where it was wrongly disabled Mar 27, 2024
@boegel boegel changed the title Enable download_dep_fail for Pythonpackage ECs where it was wrongly disabled Enable download_dep_fail in Pythonpackage easyconfigs where it was wrongly disabled Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@casparvl casparvl casparvl approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.9.1

Development

Successfully merging this pull request may close these issues.

3 participants

@Flamefire @casparvl @boegelbot