Skip to content

Fix broken homepage from older SCOTCH easyconfigs#20192

Merged
casparvl merged 1 commit intoeasybuilders:developfrom
Micket:20240322004954_new_pr_SCOTCH610
Mar 22, 2024
Merged

Fix broken homepage from older SCOTCH easyconfigs#20192
casparvl merged 1 commit intoeasybuilders:developfrom
Micket:20240322004954_new_pr_SCOTCH610

Conversation

@Micket
Copy link
Copy Markdown
Contributor

@Micket Micket commented Mar 22, 2024 •
edited
Loading

(created using eb --new-pr)
Just sick and tired of an old issue #14098 so i decided to clean out these broken urls.

This just replaces the dead homepage with the one used in the more recent easyconfigs. I went back to 2021a toolchains.

@Micket Micket added the bug fix label Mar 22, 2024
@Micket
Copy link
Copy Markdown
Contributor Author

Micket commented Mar 22, 2024

Test report by @Micket
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
vera-skylake-build - Linux Rocky Linux 8.9, x86_64, Intel Xeon Processor (Skylake, IBRS, no TSX), Python 3.6.8
See https://gist.github.com/Micket/d9d53b6aed0fbf8c113b0b6702815533 for a full test report.

@Micket
Copy link
Copy Markdown
Contributor Author

Micket commented Mar 22, 2024

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Mar 22, 2024

@Micket: Request for testing this PR well received on login1

PR test command 'EB_PR=20192 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_20192 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 13176

Test results coming soon (I hope)...

Details

- notification for comment with ID 2014128714 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Mar 22, 2024

Test report by @boegelbot
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in total)
cns1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/6978aeca3149c0accebfcb84c8ae8f85 for a full test report.

@casparvl
Copy link
Copy Markdown
Contributor

casparvl commented Mar 22, 2024

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Mar 22, 2024

@casparvl: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=20192 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_20192 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 3836

Test results coming soon (I hope)...

Details

- notification for comment with ID 2014828563 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@casparvl
Copy link
Copy Markdown
Contributor

casparvl commented Mar 22, 2024

Test report by @casparvl
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in total)
tcn1.local.snellius.surf.nl - Linux RHEL 8.6, x86_64, AMD EPYC 7H12 64-Core Processor, Python 3.6.8
See https://gist.github.com/casparvl/15e262e5c159da8b1a44ac2ad7d59d9c for a full test report.

casparvl
casparvl approved these changes Mar 22, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@casparvl casparvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@casparvl casparvl added this to the release after 4.9.0 milestone Mar 22, 2024
@casparvl
Copy link
Copy Markdown
Contributor

casparvl commented Mar 22, 2024

Going in, thanks @Micket!

@casparvl casparvl merged commit 21614b7 into easybuilders:develop Mar 22, 2024
@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Mar 22, 2024

Test report by @boegelbot
FAILED
Build succeeded for 3 out of 6 (4 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.3, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/40cf54c98db439c7679e1ba2bb72a181 for a full test report.

@casparvl
Copy link
Copy Markdown
Contributor

casparvl commented Mar 22, 2024

Failures on jsczen3 were for the intel toolchain. That makes sense, that's not there on jsczen3. Should have excluded those in the test. No matter...

@Micket Micket deleted the 20240322004954_new_pr_SCOTCH610 branch March 22, 2024 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@casparvl casparvl casparvl approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.9.1

Development

Successfully merging this pull request may close these issues.

3 participants

@Micket @boegelbot @casparvl