Skip to content

Enable LittleCMS2 and WebP support in recent Pillow#20195

Merged
casparvl merged 1 commit intoeasybuilders:developfrom
Micket:20240322155316_new_pr_Pillow1000
Mar 22, 2024
Merged

Enable LittleCMS2 and WebP support in recent Pillow#20195
casparvl merged 1 commit intoeasybuilders:developfrom
Micket:20240322155316_new_pr_Pillow1000

Conversation

@Micket
Copy link
Copy Markdown
Contributor

@Micket Micket commented Mar 22, 2024 •
edited
Loading

(created using eb --new-pr)

Because why not; we already have this deps to adding it was trivial (I have confirmed it's working as well).

Fixes #14505

@Micket
Copy link
Copy Markdown
Contributor Author

Micket commented Mar 22, 2024

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Mar 22, 2024

@Micket: Request for testing this PR well received on login1

PR test command 'EB_PR=20195 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_20195 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 13184

Test results coming soon (I hope)...

Details

- notification for comment with ID 2015392543 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@Micket
Copy link
Copy Markdown
Contributor Author

Micket commented Mar 22, 2024

Test report by @Micket
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
alvis-skylake-build - Linux Rocky Linux 8.9, x86_64, Intel Xeon Processor (Skylake, IBRS, no TSX), Python 3.6.8
See https://gist.github.com/Micket/606bb8c11a2b6d6f0c0b89fdf6423734 for a full test report.

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Mar 22, 2024

Test report by @boegelbot
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
cns2 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/23a5a2bdad5a6fc1eff04eb56070a0fe for a full test report.

@Micket
Copy link
Copy Markdown
Contributor Author

Micket commented Mar 22, 2024

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Mar 22, 2024

@Micket: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=20195 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_20195 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 3843

Test results coming soon (I hope)...

Details

- notification for comment with ID 2015411071 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Mar 22, 2024

Test report by @boegelbot
SUCCESS
Build succeeded for 7 out of 7 (3 easyconfigs in total)
jsczen3c2.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.3, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/f3fe50cc764d66f2bca7082e2e2c7ffb for a full test report.

casparvl
casparvl approved these changes Mar 22, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@casparvl casparvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@casparvl casparvl added this to the release after 4.9.0 milestone Mar 22, 2024
@casparvl
Copy link
Copy Markdown
Contributor

casparvl commented Mar 22, 2024

Test report by @casparvl
SUCCESS
Build succeeded for 8 out of 8 (3 easyconfigs in total)
tcn1.local.snellius.surf.nl - Linux RHEL 8.6, x86_64, AMD EPYC 7H12 64-Core Processor, Python 3.6.8
See https://gist.github.com/casparvl/1e687510e06315ebe5a62e3abaef140d for a full test report.

@casparvl
Copy link
Copy Markdown
Contributor

casparvl commented Mar 22, 2024

Going in, thanks @Micket!

@casparvl casparvl merged commit 136baea into easybuilders:develop Mar 22, 2024
@Micket Micket deleted the 20240322155316_new_pr_Pillow1000 branch March 22, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@casparvl casparvl casparvl approved these changes

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

4.9.1

Development

Successfully merging this pull request may close these issues.

Pillow has no support for WEBP

3 participants

@Micket @boegelbot @casparvl