Skip to content

fix python shebang in napari easyconfigs#20219

Merged
akesandgren merged 1 commit intoeasybuilders:developfrom
ThomasHoffmann77:20240326180508_new_pr_napari0415
Mar 27, 2024
Merged

fix python shebang in napari easyconfigs#20219
akesandgren merged 1 commit intoeasybuilders:developfrom
ThomasHoffmann77:20240326180508_new_pr_napari0415

Conversation

@ThomasHoffmann77
Copy link
Copy Markdown
Contributor

@ThomasHoffmann77 ThomasHoffmann77 commented Mar 26, 2024

(created using eb --new-pr)

see #19664

Copy link
Copy Markdown
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Micket Micket added this to the release after 4.9.0 milestone Mar 26, 2024
@Micket Micket added the bug fix label Mar 26, 2024
@Micket
Copy link
Copy Markdown
Contributor

Micket commented Mar 26, 2024

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

@Micket: Request for testing this PR well received on login1

PR test command 'EB_PR=20219 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_20219 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 13209

Test results coming soon (I hope)...

Details

- notification for comment with ID 2021155969 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
FAILED
Build succeeded for 2 out of 3 (3 easyconfigs in total)
cns2 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/f56bce1e1d6d00ffc6205c502e0e3bcc for a full test report.

@Micket
Copy link
Copy Markdown
Contributor

Micket commented Mar 26, 2024

@boegelbot please test @ jsc-zen3

@Micket
Copy link
Copy Markdown
Contributor

Micket commented Mar 26, 2024

was someone rebuilding GCCcore on generoso during my test? I don't understand the failure

edit: yes there was

@boegelbot
Copy link
Copy Markdown
Collaborator

@Micket: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=20219 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_20219 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 3867

Test results coming soon (I hope)...

Details

- notification for comment with ID 2021245608 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 3 out of 3 (3 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.3, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/ff43ca83fd89a625d3a8fe9b83002ce9 for a full test report.

@akesandgren
Copy link
Copy Markdown
Contributor

Going in, thanks @ThomasHoffmann77!

@akesandgren akesandgren merged commit 7004097 into easybuilders:develop Mar 27, 2024
@boegel boegel changed the title {vis}[foss/2021b,foss/2022a,foss/2023a] fix napari v0.4.1{5,8} shebang fix shebang in napari easyconfigs Apr 4, 2024
@boegel boegel changed the title fix shebang in napari easyconfigs fix python shebang in napari easyconfigs Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants