Skip to content

fix download for python-parasail 1.3.4 by adding missing source URL#20263

Merged
Micket merged 1 commit intoeasybuilders:developfrom
boegel:20240402101928_new_pr_python-parasail134
Apr 2, 2024
Merged

fix download for python-parasail 1.3.4 by adding missing source URL#20263
Micket merged 1 commit intoeasybuilders:developfrom
boegel:20240402101928_new_pr_python-parasail134

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Apr 2, 2024

(created using eb --new-pr)

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Apr 2, 2024

@boegelbot please test @ generoso
EB_ARGS="--force-download"

@boegel boegel added this to the release after 4.9.0 milestone Apr 2, 2024
@boegel boegel added the bug fix label Apr 2, 2024
@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Apr 2, 2024

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=20263 EB_ARGS="--force-download" EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_20263 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 13241

Test results coming soon (I hope)...

Details

- notification for comment with ID 2031368682 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Apr 2, 2024

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/30ba2fc7ba249600bc665f65c4b34d35 for a full test report.

@Micket
Copy link
Copy Markdown
Contributor

Micket commented Apr 2, 2024

I thought this was somehow the default in PythonPackage already?

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Apr 2, 2024

I thought this was somehow the default in PythonPackage already?

It is, but not in this case because we're using name = 'python-parasail', and the source URL uses parasail (not python-parasail)

Micket
Micket approved these changes Apr 2, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Micket Micket merged commit 17904e5 into easybuilders:develop Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Micket Micket Micket approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.9.1

Development

Successfully merging this pull request may close these issues.

3 participants

@boegel @boegelbot @Micket