Skip to content

assembly-stats/1.0.1-GCCcore-11.3.0#20281

Merged
verdurin merged 4 commits intoeasybuilders:developfrom
moravveji:assembly-stats
Apr 9, 2024
Merged

assembly-stats/1.0.1-GCCcore-11.3.0#20281
verdurin merged 4 commits intoeasybuilders:developfrom
moravveji:assembly-stats

Conversation

@moravveji
Copy link
Copy Markdown
Contributor

@moravveji moravveji commented Apr 3, 2024

I was asked to install assembly-stats for a specific bioinformatics training, and I realized that this is the first easyconfig file for this tool. A patch file is needed to improve two lines of code in the source file and make the compiler happy.
The provided easyconfig+patch file build successfully on our Intel Skylake, Cascadelake and Icelake nodes under Rocky 8.9 OS, and using GCCcore/11.3.0 from 2022a toolchain.

@moravveji moravveji mentioned this pull request Apr 3, 2024
Open
Micket
Micket previously requested changes Apr 3, 2024
View reviewed changes
Comment thread easybuild/easyconfigs/a/assembly-stats/assembly-stats-1.0.1-GCCcore-11.3.0.eb Outdated
Comment thread easybuild/easyconfigs/a/assembly-stats/assembly-stats-1.0.1_fix_str_cast.patch
Comment thread easybuild/easyconfigs/a/assembly-stats/assembly-stats-1.0.1-GCCcore-11.3.0.eb
@Micket Micket added the new label Apr 3, 2024
@moravveji
Copy link
Copy Markdown
Contributor Author

moravveji commented Apr 4, 2024

Thanks @Micket to pick up my PR. I have applied all your suggestions, and all checks pass as well. Would be good if you could take a 2nd look.

@moravveji moravveji requested a review from Micket April 4, 2024 11:42
@verdurin
Copy link
Copy Markdown
Member

verdurin commented Apr 9, 2024

Test report by @verdurin
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
easybuild-c7.novalocal - Linux CentOS Linux 7.9.2009, x86_64, Intel Xeon Processor (Skylake, IBRS), Python 3.6.8
See https://gist.github.com/verdurin/356db4a59513eb36ee9e264a29475d5c for a full test report.

@verdurin
Copy link
Copy Markdown
Member

verdurin commented Apr 9, 2024

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Apr 9, 2024

@verdurin: Request for testing this PR well received on login1

PR test command 'EB_PR=20281 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_20281 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 13266

Test results coming soon (I hope)...

Details

- notification for comment with ID 2044456056 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Apr 9, 2024

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns2 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/dd51cb708992b0210e8d20ca14906279 for a full test report.

@verdurin
Copy link
Copy Markdown
Member

verdurin commented Apr 9, 2024

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Apr 9, 2024

@verdurin: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=20281 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_20281 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 3928

Test results coming soon (I hope)...

Details

- notification for comment with ID 2044480363 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Apr 9, 2024

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.3, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/802264724b75a6fcacfc15a42411d392 for a full test report.

@verdurin verdurin added this to the release after 4.9.1 milestone Apr 9, 2024
verdurin
verdurin approved these changes Apr 9, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@verdurin verdurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

@verdurin verdurin dismissed Micket’s stale review April 9, 2024 09:25

Issues have been addressed

@verdurin
Copy link
Copy Markdown
Member

verdurin commented Apr 9, 2024

Going in, thanks @moravveji!

@verdurin verdurin merged commit 1a4de14 into easybuilders:develop Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@verdurin verdurin verdurin approved these changes

@Micket Micket Awaiting requested review from Micket

Assignees

No one assigned

Labels

new

Projects

None yet

Milestone

4.9.2

Development

Successfully merging this pull request may close these issues.

4 participants

@moravveji @verdurin @boegelbot @Micket