Test report by @VRehnberg
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
alvis-skylake-build - Linux Rocky Linux 8.9, x86_64, Intel Xeon Processor (Skylake, IBRS, no TSX), Python 3.6.8
See https://gist.github.com/VRehnberg/9823f4d395896f54500786a9c9fccaf6 for a full test report.

Test report by @VRehnberg
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
alvis-skylake-build - Linux Rocky Linux 8.9, x86_64, Intel Xeon Processor (Skylake, IBRS, no TSX), Python 3.6.8
See https://gist.github.com/VRehnberg/50403d3abb176a105fd5af02d856a336 for a full test report.

@boegelbot please test @ generoso

Test report by @verdurin
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
easybuild-c7.novalocal - Linux CentOS Linux 7.9.2009, x86_64, Intel Xeon Processor (Skylake, IBRS), Python 3.6.8
See https://gist.github.com/verdurin/873efb00a1fd349f3f8a57e28e8d5fac for a full test report.

@verdurin: Request for testing this PR well received on login1

PR test command 'EB_PR=20336 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_20336 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

• exit code: 0
• output:

Submitted batch job 13281

Test results coming soon (I hope)...

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/792d9926fc40b921a82fc1387ef18111 for a full test report.

@boegelbot please test @ jsc-zen3

@verdurin: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=20336 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_20336 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

• exit code: 0
• output:

Submitted batch job 3940

Test results coming soon (I hope)...

Perhaps I should have noted that tiktoken haven't committed their Cargo.lock file so this is what I got from using the Cargo.lock from a cargo vendor build. The test-suite runs so should be okay.

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.3, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/629d1cb1a864cdf372ff38382ddf2440 for a full test report.

Perhaps I should have noted that tiktoken haven't committed their Cargo.lock file so this is what I got from using the Cargo.lock from a cargo vendor build. The test-suite runs so should be okay.

Does it make more sense to package this as a snapshot then, with a timestamp in the version?

I don't know. It's the first time I've encountered a CargoPythonPackage where the source didn't have a Cargo.lock file so I don't know what is the current practice.

Feel free to add a timestamp (or tell me to do it)

I don't know either. I'll ask the other maintainers.

Well, even lock files don't actually lock things down completely (this is why things have broken over time before I added the cargo easyblocks to vendor all the sources).
One might think a lock with libfoo 1.2.3 might require exactly 1.2.3, but it will actually happily use 1.2.4 is it's available, as it assumes semver is fullfilled.

And cargo install foo even just ignores the lockfile unless you docargo install --locked foo

I don't think we need to add a date stamp. This is fine.

Going in, thanks @VRehnberg!