Skip to content

{chem}[foss/2022b] VAMPIRE-ASM v6.0#20368

Merged
jfgrimm merged 5 commits intoeasybuilders:developfrom
guacke:20240416145914_new_pr_VAMPIRE-ASM60
Apr 16, 2024
Merged

{chem}[foss/2022b] VAMPIRE-ASM v6.0#20368
jfgrimm merged 5 commits intoeasybuilders:developfrom
guacke:20240416145914_new_pr_VAMPIRE-ASM60

Conversation

@guacke
Copy link
Copy Markdown
Contributor

@guacke guacke commented Apr 16, 2024

(created using eb --new-pr)

Comment thread easybuild/easyconfigs/v/VAMPIRE-ASM/VAMPIRE-ASM-6.0-foss-2022b.eb Outdated
Comment thread easybuild/easyconfigs/v/VAMPIRE-ASM/VAMPIRE-ASM-6.0-foss-2022b.eb Outdated
Comment thread easybuild/easyconfigs/v/VAMPIRE-ASM/VAMPIRE-ASM-6.0-foss-2022b.eb Outdated
Comment thread easybuild/easyconfigs/v/VAMPIRE-ASM/VAMPIRE-ASM-6.0-foss-2022b.eb Outdated
Comment thread easybuild/easyconfigs/v/VAMPIRE-ASM/VAMPIRE-ASM-6.0_makefile.patch Outdated
@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented Apr 16, 2024

I would suggest switching to the MakeCp easyblock -- that way, we don't need to patch the makefile. Instead, something like:

files_to_copy = [
    (['vampire-serial', 'vampire-parallel', 'util/vdc/vdc'], 'bin'),
    (['input', 'Co.mat'], 'examples'),
    'license', 'BSD_licence', 'readme.md',
]

would do the trick

@boegel boegel added the new label Apr 16, 2024
@boegel boegel added this to the 4.x milestone Apr 16, 2024
@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented Apr 16, 2024

Test report by @jfgrimm
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
gpu25.viking2.yor.alces.network - Linux Rocky Linux 8.9, x86_64, AMD EPYC 7413 24-Core Processor, 1 x NVIDIA NVIDIA H100 PCIe, 535.161.08, Python 3.6.8
See https://gist.github.com/jfgrimm/04faeef7944a4c156cefeb1eeafabfe9 for a full test report.

@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented Apr 16, 2024

@boegelbot: please test @ jsc-zen3

@boegelbot
Copy link
Copy Markdown
Collaborator

@jfgrimm: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=20368 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_20368 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 3985

Test results coming soon (I hope)...

Details

- notification for comment with ID 2059509534 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.3, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/87820bbd31b1a6517f28a32a3e27fef2 for a full test report.

@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented Apr 16, 2024

@boegelbot: please test @ generoso

Copy link
Copy Markdown
Member

@jfgrimm jfgrimm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegelbot
Copy link
Copy Markdown
Collaborator

@jfgrimm: Request for testing this PR well received on login1

PR test command 'EB_PR=20368 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_20368 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 13315

Test results coming soon (I hope)...

Details

- notification for comment with ID 2059514099 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/8690cacef8ea811a905e7d1231a63165 for a full test report.

@jfgrimm
Copy link
Copy Markdown
Member

jfgrimm commented Apr 16, 2024

Going in, thanks @guacke!

@jfgrimm jfgrimm merged commit 85a2360 into easybuilders:develop Apr 16, 2024
@jfgrimm jfgrimm modified the milestones: 4.x, release after 4.9.1 Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants