Skip to content

add patch to fix hardcoded /bin/mv path in Rhdf5lib extension included in R-bundle-Bioconductor v3.16 + v3.18#20378

Merged
boegel merged 2 commits intoeasybuilders:developfrom
bedroge:bioconductor_patch_bin_mv_command
Apr 17, 2024
Merged

add patch to fix hardcoded /bin/mv path in Rhdf5lib extension included in R-bundle-Bioconductor v3.16 + v3.18#20378
boegel merged 2 commits intoeasybuilders:developfrom
bedroge:bioconductor_patch_bin_mv_command

Conversation

@bedroge
Copy link
Copy Markdown
Contributor

@bedroge bedroge commented Apr 16, 2024

This is now using a patch instead of the nested sed commands used in #20316.

@bedroge bedroge added bug fix EESSI Related to EESSI project labels Apr 16, 2024
@bedroge bedroge mentioned this pull request Apr 16, 2024
Closed
@bedroge
Copy link
Copy Markdown
Contributor Author

bedroge commented Apr 16, 2024

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Apr 16, 2024

@bedroge: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=20378 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_20378 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 3986

Test results coming soon (I hope)...

Details

- notification for comment with ID 2059752929 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegel boegel added this to the release after 4.9.1 milestone Apr 16, 2024
@boegel boegel changed the title fix hardcoded /bin/mv path in Bioconductor's Rhdf5lib extension fix hardcoded /bin/mv path in Rhdf5lib extension included in R-bundle-Bioconductor v3.16 + v3.18 Apr 16, 2024
boegel
boegel approved these changes Apr 16, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Apr 17, 2024

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.3, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/f7a8ceaf5cf91b06b4e88d39e0950cf7 for a full test report.

@boegel boegel changed the title fix hardcoded /bin/mv path in Rhdf5lib extension included in R-bundle-Bioconductor v3.16 + v3.18 add patch to fix hardcoded /bin/mv path in Rhdf5lib extension included in R-bundle-Bioconductor v3.16 + v3.18 Apr 17, 2024
@boegel boegel merged commit aed45af into easybuilders:develop Apr 17, 2024
@bedroge bedroge deleted the bioconductor_patch_bin_mv_command branch April 17, 2024 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

bug fix EESSI Related to EESSI project

Projects

None yet

Milestone

4.9.2

Development

Successfully merging this pull request may close these issues.

3 participants

@bedroge @boegelbot @boegel