Skip to content

add hatch-requirements-txt extension to hatchling easyconfigs#20389

Merged
Micket merged 1 commit intoeasybuilders:developfrom
migueldiascosta:20240418063140_new_pr_hatchling1180
Apr 19, 2024
Merged

add hatch-requirements-txt extension to hatchling easyconfigs#20389
Micket merged 1 commit intoeasybuilders:developfrom
migueldiascosta:20240418063140_new_pr_hatchling1180

Conversation

@migueldiascosta
Copy link
Copy Markdown
Member

@migueldiascosta migueldiascosta commented Apr 17, 2024 •
edited by boegel
Loading

(created using eb --new-pr)

motivated by https://github.com/easybuilders/easybuild-easyconfigs/pull/20349/files#r1568013373

edit (by @boegel): this is a fix for:

hatchling.plugin.exceptions.UnknownPluginError: Unknown metadata hook: requirements_txt

@migueldiascosta migueldiascosta added this to the release after 4.9.1 milestone Apr 17, 2024
@migueldiascosta
Copy link
Copy Markdown
Member Author

migueldiascosta commented Apr 17, 2024

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Apr 17, 2024

@migueldiascosta: Request for testing this PR well received on login1

PR test command 'EB_PR=20389 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_20389 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 13330

Test results coming soon (I hope)...

Details

- notification for comment with ID 2062611496 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Apr 17, 2024

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
cns1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/34ac46e9e0eed539df266db2f81daf58 for a full test report.

@migueldiascosta
Copy link
Copy Markdown
Member Author

migueldiascosta commented Apr 17, 2024

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Apr 17, 2024

@migueldiascosta: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=20389 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_20389 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 3998

Test results coming soon (I hope)...

Details

- notification for comment with ID 2062625983 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Apr 17, 2024

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.3, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/8ce4bdf5b90c5e89564e8879df2aec5a for a full test report.

@migueldiascosta migueldiascosta mentioned this pull request Apr 17, 2024
Merged
@migueldiascosta migueldiascosta requested a review from Micket April 18, 2024 22:26
Micket
Micket approved these changes Apr 19, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Micket Micket merged commit 9580c0d into easybuilders:develop Apr 19, 2024
lorisercole added a commit to lorisercole/eessi-software-layer that referenced this pull request Feb 3, 2026
@lorisercole
{2023.06}[sapphirerapids] Redo rebuild of hatchling 1.18.0
cef3126 
The current build of `hatchling` 1.18.0 on sapphirerapids on EESSI appears to include the `typing-extensions` extension,
which however was removed in the updated easyconfigs (see easybuilders/easybuild-easyconfigs#20389).

Several rebuilds on sapphirerapids were carried out:
- 20250223: EESSI#933
- 20250228: EESSI#955
- 20250425: EESSI#955
but I am not sure why the obsolete `typing-extensions` package was not correctly cleaned up.
Currently, this extension can be found at these paths:
```
/cvmfs/software.eessi.io/versions/2023.06/software/linux/x86_64/intel/sapphirerapids/software/hatchling/1.18.0-GCCcore-12.3.0/lib/python3.11/site-packages/typing_extensions-4.6.3.dist-info
/cvmfs/software.eessi.io/versions/2023.06/software/linux/x86_64/intel/sapphirerapids/software/hatchling/1.18.0-GCCcore-12.3.0/lib/python3.11/site-packages/typing_extensions.py
/cvmfs/software.eessi.io/versions/2023.06/software/linux/x86_64/intel/sapphirerapids/software/hatchling/1.18.0-GCCcore-13.2.0/lib/python3.11/site-packages/typing_extensions-4.8.0.dist-info
/cvmfs/software.eessi.io/versions/2023.06/software/linux/x86_64/intel/sapphirerapids/software/hatchling/1.18.0-GCCcore-13.2.0/lib/python3.11/site-packages/typing_extensions.py
```
It is not installed in any other target.

This leftover extension recently caused a conflict and a build error on sapphirerapids:
EESSI#1334 (comment)

It should then be rebuilt, making sure to clean up the old artifacts, and verifying that it not accidentally reinstalled.
@lorisercole lorisercole mentioned this pull request Feb 3, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Micket Micket Micket approved these changes

Assignees

No one assigned

Labels

change enhancement

Projects

None yet

Milestone

4.9.2

Development

Successfully merging this pull request may close these issues.

3 participants

@migueldiascosta @boegelbot @Micket