Skip to content

add missing (optional) dependency pyproject-metadata to scikit-build-core#20391

Merged
bedroge merged 1 commit intoeasybuilders:developfrom
boegel:20240418085037_new_pr_scikit-build-core050
Apr 22, 2024
Merged

add missing (optional) dependency pyproject-metadata to scikit-build-core#20391
bedroge merged 1 commit intoeasybuilders:developfrom
boegel:20240418085037_new_pr_scikit-build-core050

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Apr 18, 2024 •
edited
Loading

(created using eb --new-pr)

Some software that uses scikit-build-core uses functionality that requires an extra (optional?) dependency.
This fixes:

  Traceback (most recent call last):
    File "/software/Python/3.11.3-GCCcore-12.3.0/lib/python3.11/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 353, in <module>
      main()
    File "/software/Python/3.11.3-GCCcore-12.3.0/lib/python3.11/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 335, in main
      json_out['return_val'] = hook(**hook_input['kwargs'])
                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    File "/software/Python/3.11.3-GCCcore-12.3.0/lib/python3.11/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 149, in prepare_metadata_for_build_wheel
      return hook(metadata_directory, config_settings)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    File "/software/scikit-build-core/0.5.0-GCCcore-12.3.0/lib/python3.11/site-packages/scikit_build_core/build/__init__.py", line 71, in prepare_metadata_for_build_wheel
      from .wheel import _build_wheel_impl
    File "/software/scikit-build-core/0.5.0-GCCcore-12.3.0/lib/python3.11/site-packages/scikit_build_core/build/wheel.py", line 21, in <module>
      from ..settings.metadata import get_standard_metadata
    File "/software/scikit-build-core/0.5.0-GCCcore-12.3.0/lib/python3.11/site-packages/scikit_build_core/settings/metadata.py", line 7, in <module>
      from pyproject_metadata import StandardMetadata
  ModuleNotFoundError: No module named 'pyproject_metadata'

I bumped into this during the installation of lightgbm (as a dependency for CheckM2)

@boegel boegel added this to the release after 4.9.1 milestone Apr 18, 2024
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Apr 18, 2024

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Apr 18, 2024

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=20391 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_20391 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 13332

Test results coming soon (I hope)...

Details

- notification for comment with ID 2063150266 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Apr 18, 2024

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/2c67d288ab91091e7268a43a6385fe39 for a full test report.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Apr 18, 2024

@boegelbot please test @ jsc-zen3

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Apr 18, 2024

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3164.skitty.os - Linux RHEL 8.8, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 3.6.8
See https://gist.github.com/boegel/49783611d53383a77c73aec3daff02db for a full test report.

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Apr 18, 2024

@boegel: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=20391 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_20391 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 4000

Test results coming soon (I hope)...

Details

- notification for comment with ID 2063185986 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Apr 18, 2024

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.3, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/a5614833c6d4c9639c8f8c6e812e3876 for a full test report.

@boegel boegel mentioned this pull request Apr 18, 2024
Closed
@bedroge
Copy link
Copy Markdown
Contributor

bedroge commented Apr 22, 2024

Test report by @bedroge
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
bob-Latitude-5300 - Linux Ubuntu 22.04, x86_64, Intel(R) Core(TM) i7-8665U CPU @ 1.90GHz, Python 3.10.12
See https://gist.github.com/bedroge/334ab1eb1fb499bbef0b0dfcf1cbfd9b for a full test report.

bedroge
bedroge approved these changes Apr 22, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@bedroge bedroge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@bedroge
Copy link
Copy Markdown
Contributor

bedroge commented Apr 22, 2024

Going in, thanks @boegel!

@bedroge bedroge merged commit 61b14c8 into easybuilders:develop Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bedroge bedroge bedroge approved these changes

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

4.9.2

Development

Successfully merging this pull request may close these issues.

3 participants

@boegel @boegelbot @bedroge