Skip to content

add patch to increase compatibility with AVX512 platforms for bwa-mem2 v2.2.1#20434

Merged
boegel merged 2 commits intoeasybuilders:developfrom
lexming:bwa-mem2-avx512
Jun 8, 2024
Merged

add patch to increase compatibility with AVX512 platforms for bwa-mem2 v2.2.1#20434
boegel merged 2 commits intoeasybuilders:developfrom
lexming:bwa-mem2-avx512

Conversation

@lexming
Copy link
Copy Markdown
Contributor

@lexming lexming commented Apr 29, 2024

No description provided.

verdurin
verdurin previously requested changes Apr 29, 2024
View reviewed changes
Comment thread easybuild/easyconfigs/b/bwa-mem2/bwa-mem2-2.2.1-intel-compilers-2023.1.0.eb Outdated
@lexming
Copy link
Copy Markdown
Contributor Author

lexming commented Apr 30, 2024

@boegelbot: please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Apr 30, 2024

@lexming: Request for testing this PR well received on login1

PR test command 'EB_PR=20434 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_20434 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 13371

Test results coming soon (I hope)...

Details

- notification for comment with ID 2084504358 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Apr 30, 2024

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/b952dd2949b372fd0e59367a8da9f4d3 for a full test report.

@lexming
Copy link
Copy Markdown
Contributor Author

lexming commented Apr 30, 2024

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Apr 30, 2024

@lexming: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=20434 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_20434 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 4044

Test results coming soon (I hope)...

Details

- notification for comment with ID 2084523585 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Apr 30, 2024

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (1 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.3, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/b57e8abf00cc47b625b337956948dab8 for a full test report.

@lexming
Copy link
Copy Markdown
Contributor Author

lexming commented Apr 30, 2024

Test report by @lexming
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node600.hydra.os - Linux Rocky Linux 8.9, x86_64, AMD EPYC 9384X 32-Core Processor (x86_64_v4), Python 3.6.8
See https://gist.github.com/lexming/4967cd0e41fbd28eee54c58ebe38e188 for a full test report.

@lexming
Copy link
Copy Markdown
Contributor Author

lexming commented Apr 30, 2024

Test report by @lexming
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node300.hydra.os - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz (skylake_avx512), Python 3.6.8
See https://gist.github.com/lexming/af8a6262bcaa3febd074027969fd7e11 for a full test report.

@boegel boegel changed the title increase compatibility with AVX512 platforms of bwa-mem2 v2.2.1 add patch to increase compatibility with AVX512 platforms for bwa-mem2 v2.2.1 Jun 8, 2024
@boegel
Copy link
Copy Markdown
Member

boegel commented Jun 8, 2024

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (1 easyconfigs in total)
node3117.skitty.os - Linux RHEL 8.8, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 3.6.8
See https://gist.github.com/boegel/1c05ba7df1d0221d4a7e2a8dda13ef39 for a full test report.

@boegel boegel added this to the 4.9.2 milestone Jun 8, 2024
@boegel boegel dismissed verdurin’s stale review June 8, 2024 15:35

requested changes made

boegel
boegel approved these changes Jun 8, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Copy Markdown
Member

boegel commented Jun 8, 2024

Going in, thanks @lexming!

@boegel boegel merged commit 63defc1 into easybuilders:develop Jun 8, 2024
@lexming lexming deleted the bwa-mem2-avx512 branch June 10, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

@verdurin verdurin verdurin left review comments

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.9.2

Development

Successfully merging this pull request may close these issues.

4 participants

@lexming @boegelbot @boegel @verdurin