Skip to content

add patch for GROMACS 2024.1 to fix filesystem race in tests#20439

Merged
ocaisa merged 2 commits intoeasybuilders:developfrom
boegel:20240430110124_new_pr_GROMACS20241
Apr 30, 2024
Merged

add patch for GROMACS 2024.1 to fix filesystem race in tests#20439
ocaisa merged 2 commits intoeasybuilders:developfrom
boegel:20240430110124_new_pr_GROMACS20241

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented Apr 30, 2024

(created using eb --new-pr)

@boegel boegel added the bug fix label Apr 30, 2024
@boegel boegel added this to the release after 4.9.1 milestone Apr 30, 2024
@boegel
Copy link
Copy Markdown
Member Author

boegel commented Apr 30, 2024

@boegelbot please test @ generoso
CORE_CNT=16

@boegel boegel mentioned this pull request Apr 30, 2024
Merged
@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Apr 30, 2024

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=20439 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_20439 --ntasks="16" ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 13372

Test results coming soon (I hope)...

Details

- notification for comment with ID 2084776584 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Apr 30, 2024

@boegelbot please test @ jsc-zen3
CORE_CNT=16

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Apr 30, 2024

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cnx1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/a0e595857e6b97f39581332786a0fabf for a full test report.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented Apr 30, 2024

@boegelbot please test @ jsc-zen3
CORE_CNT=16

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Apr 30, 2024

@boegel: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=20439 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_20439 --ntasks="16" ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 4049

Test results coming soon (I hope)...

Details

- notification for comment with ID 2086240733 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented Apr 30, 2024

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen3c2.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.3, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/cc1f4b1254431c4a502cea207e12a4a1 for a full test report.

ocaisa
ocaisa reviewed Apr 30, 2024
View reviewed changes
Comment thread easybuild/easyconfigs/g/GROMACS/GROMACS-2024.1-foss-2023b.eb Outdated
ocaisa
ocaisa approved these changes Apr 30, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@ocaisa ocaisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed a linting issue that doesn't affect the test builds

@ocaisa ocaisa enabled auto-merge April 30, 2024 19:52
@ocaisa ocaisa merged commit 9a09523 into easybuilders:develop Apr 30, 2024
@boegel boegel deleted the 20240430110124_new_pr_GROMACS20241 branch April 30, 2024 20:23
@satishskamath
Copy link
Copy Markdown
Contributor

satishskamath commented May 1, 2024 •
edited
Loading

I am not using this patch but the tests are passing now at least on zen2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ocaisa ocaisa ocaisa approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.9.2

Development

Successfully merging this pull request may close these issues.

4 participants

@boegel @boegelbot @satishskamath @ocaisa