Skip to content

add RISC-V support to BLIS 0.9.0#20468

Merged
boegel merged 2 commits intoeasybuilders:developfrom
bedroge:blis_0.9.0_add_riscv_support
May 3, 2024
Merged

add RISC-V support to BLIS 0.9.0#20468
boegel merged 2 commits intoeasybuilders:developfrom
bedroge:blis_0.9.0_add_riscv_support

Conversation

@bedroge
Copy link
Copy Markdown
Contributor

@bedroge bedroge commented May 3, 2024

RISC-V support has been added on the master branch of BLIS, this PR backports it to version 0.9.0. As it's not part of the official release, I've added an if statement that only applies the patch on RISC-V hosts.

@bedroge bedroge added enhancement EESSI Related to EESSI project riscv labels May 3, 2024
@bedroge
Copy link
Copy Markdown
Contributor Author

bedroge commented May 3, 2024

@boegelbot please test @ jsc-zen3

@bedroge bedroge mentioned this pull request May 3, 2024
Open
@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented May 3, 2024

@bedroge: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=20468 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_20468 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 4064

Test results coming soon (I hope)...

Details

- notification for comment with ID 2092993267 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented May 3, 2024

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen3c2.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.3, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/999f33c988cd3d34a11437181ac5809a for a full test report.

@SebastianAchilles SebastianAchilles added this to the release after 4.9.1 milestone May 3, 2024
@SebastianAchilles
Copy link
Copy Markdown
Member

SebastianAchilles commented May 3, 2024

Test report by @SebastianAchilles
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
arriesgado-3 - Linux Ubuntu 22.04, RISC-V-64, UNKNOWN (u74mc), Python 3.10.12
See https://gist.github.com/SebastianAchilles/246763ce0be617259085ad60699c669b for a full test report.

boegel
boegel approved these changes May 3, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Copy Markdown
Member

boegel commented May 3, 2024

@boegelbot please test @ generoso

@boegel
Copy link
Copy Markdown
Member

boegel commented May 3, 2024

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3147.skitty.os - Linux RHEL 8.8, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 3.6.8
See https://gist.github.com/boegel/36dd8a0dcda78e9f8b6efeea6b69da7b for a full test report.

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented May 3, 2024

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=20468 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_20468 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 13401

Test results coming soon (I hope)...

Details

- notification for comment with ID 2093176374 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented May 3, 2024

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/fc1b45288297c9cfbbe5f62612834b6b for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented May 3, 2024

Going in, thanks @bedroge!

@boegel boegel merged commit f37ff45 into easybuilders:develop May 3, 2024
@bedroge bedroge deleted the blis_0.9.0_add_riscv_support branch May 3, 2024 15:07
@bedroge
Copy link
Copy Markdown
Contributor Author

bedroge commented May 3, 2024

Test report by @bedroge
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
starfive - Linux Debian GNU/Linux 2.15, RISC-V-64, UNKNOWN, Python 3.10.9
See https://gist.github.com/bedroge/93ffd0ac839b9eede422a86288982bfb for a full test report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

EESSI Related to EESSI project enhancement riscv

Projects

None yet

Milestone

4.9.2

Development

Successfully merging this pull request may close these issues.

4 participants

@bedroge @boegelbot @SebastianAchilles @boegel