Skip to content

Fix detection of CC/CXX compilers for wmake in OpenFOAM v2306 + v2312#20517

Merged
boegel merged 2 commits intoeasybuilders:developfrom
ocaisa:20240513131824_new_pr_OpenFOAMv2312
Jun 7, 2024
Merged

Fix detection of CC/CXX compilers for wmake in OpenFOAM v2306 + v2312#20517
boegel merged 2 commits intoeasybuilders:developfrom
ocaisa:20240513131824_new_pr_OpenFOAMv2312

Conversation

@ocaisa
Copy link
Copy Markdown
Member

@ocaisa ocaisa commented May 13, 2024 •
edited
Loading

@ocaisa ocaisa changed the title Fix detection of CC/CXX compilers for wmake for dot_com OpenFOAM Fix detection of CC/CXX compilers for wmake of dot_com OpenFOAM May 13, 2024
@ocaisa
Copy link
Copy Markdown
Member Author

ocaisa commented May 13, 2024 •
edited
Loading

@boegelbot please test @ jsc-zen3
EB_ARGS="--include-easyblocks-from-pr 3328"

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented May 13, 2024

@ocaisa: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=20517 EB_ARGS="--include-easyblocks-from-pr 3328" EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_20517 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 4112

Test results coming soon (I hope)...

Details

- notification for comment with ID 2107607979 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@ocaisa ocaisa mentioned this pull request May 13, 2024
Closed
@ocaisa
Copy link
Copy Markdown
Member Author

ocaisa commented May 13, 2024

@boegelbot please test @ generoso
EB_ARGS="--include-easyblocks-from-pr 3328"

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented May 13, 2024

@ocaisa: Request for testing this PR well received on login1

PR test command 'EB_PR=20517 EB_ARGS="--include-easyblocks-from-pr 3328" EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_20517 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 13451

Test results coming soon (I hope)...

Details

- notification for comment with ID 2107687128 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented May 13, 2024

Test report by @boegelbot
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#3328
SUCCESS
Build succeeded for 2 out of 2 (1 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.4, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/e7455c12df2c80373db79e1d08193787 for a full test report.

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented May 13, 2024

Test report by @boegelbot
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#3328
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
cns1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/2893581cc2f1a61a57cdfdcd63724b32 for a full test report.

@boegel boegel added the bug fix label May 23, 2024
@boegel boegel added this to the release after 4.9.1 milestone May 23, 2024
@ocaisa ocaisa mentioned this pull request Jun 6, 2024
Merged
@boegel boegel changed the title Fix detection of CC/CXX compilers for wmake of dot_com OpenFOAM Fix detection of CC/CXX compilers for wmake in OpenFOAM v2212, v2306, v2312 Jun 7, 2024
@boegel
Copy link
Copy Markdown
Member

boegel commented Jun 7, 2024

Test report by @boegel
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#3328
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
node3117.skitty.os - Linux RHEL 8.8, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 3.6.8
See https://gist.github.com/boegel/f21dc6a51405327c360f8ace64a1f7b7 for a full test report.

@boegel boegel changed the title Fix detection of CC/CXX compilers for wmake in OpenFOAM v2212, v2306, v2312 Fix detection of CC/CXX compilers for wmake in OpenFOAM v2306 + v2312 Jun 7, 2024
boegel
boegel approved these changes Jun 7, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Copy Markdown
Member

boegel commented Jun 7, 2024

Going in, thanks @ocaisa!

@boegel boegel merged commit cf3b824 into easybuilders:develop Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

4.9.2

Development

Successfully merging this pull request may close these issues.

3 participants

@ocaisa @boegelbot @boegel