Skip to content

{cae}[system/system] HEEDS v2310#20545

Merged
akesandgren merged 6 commits intoeasybuilders:developfrom
Micket:20240516163713_new_pr_HEEDS2310
May 14, 2025
Merged

{cae}[system/system] HEEDS v2310#20545
akesandgren merged 6 commits intoeasybuilders:developfrom
Micket:20240516163713_new_pr_HEEDS2310

Conversation

@Micket
Copy link
Copy Markdown
Contributor

@Micket Micket commented May 16, 2024

(created using eb --new-pr)

@Micket Micket added the new label May 16, 2024
@Micket Micket marked this pull request as draft May 16, 2024 18:03
@Micket Micket added this to the 5.0 milestone May 17, 2024
@Micket
Copy link
Copy Markdown
Contributor Author

Micket commented May 17, 2024

I used f-strings. I hate the old format strings. So, 5.0 only.

@Micket
Copy link
Copy Markdown
Contributor Author

Micket commented May 20, 2024

Test report by @Micket
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
vera-icelake-build - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) Silver 4316 CPU @ 2.30GHz, Python 3.6.8
See https://gist.github.com/Micket/57f2dfcce0218ccf3f164c6e413f3b81 for a full test report.

@Micket Micket marked this pull request as ready for review May 20, 2024 09:34
@Micket
Copy link
Copy Markdown
Contributor Author

Micket commented May 20, 2024

Test report by @Micket
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
vera-icelake-build - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) Silver 4316 CPU @ 2.30GHz, Python 3.6.8
See https://gist.github.com/Micket/4eef20f0aa542a5056f5bf7fee98c03b for a full test report.

@Micket
Copy link
Copy Markdown
Contributor Author

Micket commented May 21, 2024

Also tested running the application and it works fine (unfortunately no good sanity check command to test)

@boegel boegel modified the milestones: 5.0.0, release after 5.0.0 Mar 18, 2025
akesandgren
akesandgren approved these changes May 14, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@akesandgren akesandgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akesandgren
Copy link
Copy Markdown
Contributor

akesandgren commented May 14, 2025

Going in, thanks @Micket!

@akesandgren akesandgren merged commit e6473b3 into easybuilders:develop May 14, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akesandgren akesandgren akesandgren approved these changes

Assignees

No one assigned

Labels

new

Projects

None yet

Milestone

5.1.0

Development

Successfully merging this pull request may close these issues.

3 participants

@Micket @akesandgren @boegel