Skip to content

add rhandsontable extension to R-bundle-CRAN v2023.12#20614

Merged
smoors merged 1 commit intoeasybuilders:developfrom
boegel:20240523134736_new_pr_R-bundle-CRAN202312
May 23, 2024
Merged

add rhandsontable extension to R-bundle-CRAN v2023.12#20614
smoors merged 1 commit intoeasybuilders:developfrom
boegel:20240523134736_new_pr_R-bundle-CRAN202312

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented May 23, 2024 •
edited
Loading

(created using eb --new-pr)

This removed the dedicated easyconfig for rhandsontable that was contributed by @PetrKralCZ in #20537, I don't see a need to have it standalone as opposed to just including it in the existing R-bundle-CRAN module...

@boegel boegel added this to the release after 4.9.1 milestone May 23, 2024
@boegel boegel requested a review from smoors May 23, 2024 11:52
@boegel
Copy link
Copy Markdown
Member Author

boegel commented May 23, 2024

@boegelbot please test @ generoso
EB_ARGS="--skip"

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented May 23, 2024

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=20614 EB_ARGS="--skip" EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_20614 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 13533

Test results coming soon (I hope)...

Details

- notification for comment with ID 2126920678 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented May 23, 2024

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns2 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/554942ac9e307ce8aef31e9342cd0c33 for a full test report.

@boegel
Copy link
Copy Markdown
Member Author

boegel commented May 23, 2024

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3147.skitty.os - Linux RHEL 8.8, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 3.6.8
See https://gist.github.com/boegel/285a7d09be55f6f1c307ad42871d73b5 for a full test report.

@smoors
Copy link
Copy Markdown
Contributor

smoors commented May 23, 2024

@boegelbot please test @ jsc-zen3 EB_ARGS="--skip"

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented May 23, 2024

@smoors: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=20614 EB_ARGS="--skip" EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_20614 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 4190

Test results coming soon (I hope)...

Details

- notification for comment with ID 2127302323 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

boegelbot commented May 23, 2024

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.4, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/3410e22aa4bdba6606accffefbbe62ce for a full test report.

smoors
smoors approved these changes May 23, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@smoors smoors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smoors
Copy link
Copy Markdown
Contributor

smoors commented May 23, 2024

Going in, thanks @boegel!

@smoors smoors merged commit ce359bc into easybuilders:develop May 23, 2024
@boegel boegel deleted the 20240523134736_new_pr_R-bundle-CRAN202312 branch May 23, 2024 18:22
@boegel boegel mentioned this pull request May 23, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smoors smoors smoors approved these changes

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

4.9.2

Development

Successfully merging this pull request may close these issues.

3 participants

@boegel @boegelbot @smoors